emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* bug: [[file:something.org]] is exported to [[http:something.html]]
@ 2010-09-07 20:42 Daniel Clemente
  2010-09-07 21:41 ` [PATCH] " Noorul Islam
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Clemente @ 2010-09-07 20:42 UTC (permalink / raw)
  To: org-mode Mailinglist; +Cc: Noorul Islam


Commit bd1b57f92a33485c90db1efc407c8b7c7450993a (Thu Sep 2 11:35:43 2010 +0000) did something like this in org-html.el:

               ((str (org-export-html-format-href thefile)))
-             (if (and type (not (string= "file" type))
-                      (org-string-match-p "^//" str))
+             (if (and type (not (string= "file" type)))
                  (concat type ":" str)


This broke the exporting of [[file:a.org]] links, which now appear as [[http:a.html]]. Try C-c C-e H on any .org with such links, even in emacs -Q.

The problem is, I think, that „type“ is actually "http", not "file" as the code tries.

-- Daniel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] Re: bug: [[file:something.org]] is exported to [[http:something.html]]
  2010-09-07 20:42 bug: [[file:something.org]] is exported to [[http:something.html]] Daniel Clemente
@ 2010-09-07 21:41 ` Noorul Islam
  2010-09-12 18:06   ` David Maus
  0 siblings, 1 reply; 3+ messages in thread
From: Noorul Islam @ 2010-09-07 21:41 UTC (permalink / raw)
  To: Daniel Clemente; +Cc: org-mode Mailinglist

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

On Wed, Sep 8, 2010 at 2:12 AM, Daniel Clemente <n142857@gmail.com> wrote:
>
> Commit bd1b57f92a33485c90db1efc407c8b7c7450993a (Thu Sep 2 11:35:43 2010 +0000) did something like this in org-html.el:
>
>               ((str (org-export-html-format-href thefile)))
> -             (if (and type (not (string= "file" type))
> -                      (org-string-match-p "^//" str))
> +             (if (and type (not (string= "file" type)))
>                  (concat type ":" str)
>
>
> This broke the exporting of [[file:a.org]] links, which now appear as [[http:a.html]]. Try C-c C-e H on any .org with such links, even in emacs -Q.
>
> The problem is, I think, that „type“ is actually "http", not "file" as the code tries.

I think the problem is here.

org-html.el: Fix exporting link to .org files.

* lisp/org-html.el (org-html-cvt-org-as-html): Do not convert protocol
from 'file' to 'http'

Thanks and Regards
Noorul

[-- Attachment #2: org-html.el.txt --]
[-- Type: text/plain, Size: 357 bytes --]

diff --git a/lisp/org-html.el b/lisp/org-html.el
index 5da2a5f..1a96fa1 100644
--- a/lisp/org-html.el
+++ b/lisp/org-html.el
@@ -674,7 +674,7 @@ See variable `org-export-html-link-org-files-as-html'"
 	 (string-match "\\.org$" path)
 	 (progn
 	    (list
-	       "http"
+	       "file"
 	       (concat
 		  (substring path 0 (match-beginning 0))
 		  "."

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Re: bug: [[file:something.org]] is exported to [[http:something.html]]
  2010-09-07 21:41 ` [PATCH] " Noorul Islam
@ 2010-09-12 18:06   ` David Maus
  0 siblings, 0 replies; 3+ messages in thread
From: David Maus @ 2010-09-12 18:06 UTC (permalink / raw)
  To: Noorul Islam; +Cc: org-mode Mailinglist


[-- Attachment #1.1: Type: text/plain, Size: 340 bytes --]

Noorul Islam wrote:

>I think the problem is here.

>org-html.el: Fix exporting link to .org files.

>* lisp/org-html.el (org-html-cvt-org-as-html): Do not convert protocol
>from 'file' to 'http'

Thanks, patch accepted and applied.

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-09-12 18:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-07 20:42 bug: [[file:something.org]] is exported to [[http:something.html]] Daniel Clemente
2010-09-07 21:41 ` [PATCH] " Noorul Islam
2010-09-12 18:06   ` David Maus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).