From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: org mobile - pre hooks
Date: Sun, 06 Mar 2011 01:17:08 +0100
Message-ID: <87tyfhf6gr.fsf@gnu.org>
References: <t1ipvzyjo9.fsf@news.eternal-september.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=43443 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pw1ez-0002xr-K1
	for emacs-orgmode@gnu.org; Sat, 05 Mar 2011 19:17:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1Pw1ey-0006Wb-AI
	for emacs-orgmode@gnu.org; Sat, 05 Mar 2011 19:17:21 -0500
Received: from mail-ww0-f49.google.com ([74.125.82.49]:56530)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1Pw1ey-0006WU-0S
	for emacs-orgmode@gnu.org; Sat, 05 Mar 2011 19:17:20 -0500
Received: by wwj40 with SMTP id 40so3360813wwj.30
	for <emacs-orgmode@gnu.org>; Sat, 05 Mar 2011 16:17:19 -0800 (PST)
In-Reply-To: <t1ipvzyjo9.fsf@news.eternal-september.org> (Richard Riley's
	message of "Thu, 03 Mar 2011 22:32:22 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Richard Riley <rileyrg@googlemail.com>
Cc: Emacs-orgmode mailing list <emacs-orgmode@gnu.org>

--=-=-=
Content-Type: text/plain

Hi Richard,

Richard Riley <rileyrg@googlemail.com> writes:

> Could I suggest that org-mobile-pre-push-hook is processed at the start
> of the org-mobile-push function before the checks? That way it can be
> used to properly setup mobile e.g using auth-source for the mobile
> password.

This trivial patch will perhaps do.  I'm not using org-mobile.el so
please let me know if there are any side-effects.

Thanks,


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=org-mobile.el.patch

diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index 5471734..ffdd92c 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -305,9 +305,9 @@ create all custom agenda views, for upload to the mobile phone."
 	  (org-agenda-redo-command org-agenda-redo-command))
       (save-excursion
 	(save-window-excursion
+	  (run-hooks 'org-mobile-pre-push-hook)
 	  (org-mobile-check-setup)
 	  (org-mobile-prepare-file-lists)
-	  (run-hooks 'org-mobile-pre-push-hook)
 	  (message "Creating agendas...")
 	  (let ((inhibit-redisplay t)) (org-mobile-create-sumo-agenda))
 	  (message "Creating agendas...done")

--=-=-=
Content-Type: text/plain


-- 
 Bastien

--=-=-=--