From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Schulte" Subject: Re: Build error in git HEAD with org-bibtex.el Date: Thu, 28 Apr 2011 09:21:37 -0600 Message-ID: <87tydibdvi.fsf@gmail.com> References: <87vcxyvcbn.fsf@sbs.ch> <87vcxyv8o4.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:48743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFT2L-0002VD-6T for emacs-orgmode@gnu.org; Thu, 28 Apr 2011 11:21:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QFT2G-0006r8-8p for emacs-orgmode@gnu.org; Thu, 28 Apr 2011 11:21:49 -0400 Received: from mail-px0-f179.google.com ([209.85.212.179]:41597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFT2G-0006r0-1s for emacs-orgmode@gnu.org; Thu, 28 Apr 2011 11:21:44 -0400 Received: by pxi2 with SMTP id 2so129692pxi.38 for ; Thu, 28 Apr 2011 08:21:43 -0700 (PDT) In-Reply-To: <87vcxyv8o4.fsf@fastmail.fm> (Matt Lundin's message of "Thu, 28 Apr 2011 08:53:47 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Matt Lundin Cc: emacs-orgmode@gnu.org, Christian Egli Matt Lundin writes: > Christian Egli writes: > >> Hi all >> >> When doing a `make update` I get the following compile error: >> >> ~/src/org-mode $ make update >> git pull >> Already up-to-date. >> /usr/bin/make clean >> make[1]: Entering directory `/home/eglic/src/org-mode' >> [snip] >> emacs -batch -q -no-site-file -eval "(setq load-path (cons >> (expand-file-name \"./lisp/\") (cons >> \"/usr/local/share/emacs/site-lisp\" load-path)))" -f >> batch-byte-compile lisp/org-bibtex.el >> >> In toplevel form: >> lisp/org-bibtex.el:257:8:Error: Byte-compiling a redefinition of `get' >> will not work - use `labels' instead >> make[1]: *** [lisp/org-bibtex.elc] Error 1 >> make[1]: Leaving directory `/home/eglic/src/org-mode' >> make: *** [update] Error 2 >> >> This is using GNU Emacs 23.1.1 (x86_64-pc-linux-gnu, GTK+ Version >> 2.22.0) of 2011-03-04 on yellow, modified by Debian >> > > And with bleeding edge emacs (compiled from the repos yesterday), I'm > getting an additional error: > > In toplevel form: > org-bibtex.el:114:1:Warning: global/dynamic var `description' lacks a prefix > org-bibtex.el:257:1:Error: Byte-compiling a redefinition of `get' will not work - use `labels' instead > make: *** [lisp/org-bibtex.elc] Error 1 > > Note: the description variable error has nothing to do with the recent > changes to org-bibtex. > Hi Matt, Yes, the org-mode source is littered with such un-prefixed dynamic variables, and I'm not sure how this will be addressed. Personally I would prefer an option to tell the compiler not to complain, as adding org- to all of these variable names could make the source harder to read. But, that said, I suppose there is a danger of conflict in common variable names between packages... Thanks -- Eric > > Best, > Matt > > -- Eric Schulte http://cs.unm.edu/~eschulte/