emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric Schulte <schulte.eric@gmail.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/ob.el (org-babel-result-cond)
Date: Tue, 11 Dec 2012 07:41:29 -0700	[thread overview]
Message-ID: <87txrsmpy1.fsf@gmail.com> (raw)
In-Reply-To: 877gotiqnp.fsf@Rainer.invalid

Achim Gratz <Stromeko@nexgo.de> writes:

> This has been in there for a while and only been visible due to
> byte-compiler warnings about free variable result-params.  Either the
> tests don't really exercise this code path well or we've been lucky that
> result-params was bound to the correct value during all those calls.
>

The `result-params' variable is *always* in scope every time this macro
is called.  In fact previously the Babel language files were told to
expect some variables to always be in scope without their being
explicitly passed in as parameters.  We've since begun passing these
things explicitly to the language functions to appease the compiler.

I'd like to apply this patch, however the format is not detected by git
am.  Could you re-generate this patch using git format-patch and attach
the resulting file?

Thanks,

-- 
Eric Schulte
http://cs.unm.edu/~eschulte

  reply	other threads:[~2012-12-11 18:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-07 19:54 [PATCH] lisp/ob.el (org-babel-result-cond) Achim Gratz
2012-12-11 14:41 ` Eric Schulte [this message]
2012-12-11 18:21   ` Achim Gratz
2012-12-12  0:26     ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txrsmpy1.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).