emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: compilation issues of new export framework
Date: Sun, 10 Feb 2013 11:44:20 +0100	[thread overview]
Message-ID: <87txpko3cr.fsf@Rainer.invalid> (raw)
In-Reply-To: 877gmhs7f4.fsf@gmail.com

Nicolas Goaziou writes:
> Yes, I noticed this one too, but I don't know yet from where it could
> come from.

It comes from the two autoloads, or probably only the second one as the
first is later declare-function'ed anyway.  If you declare these, then
the defsubst get sometimes compiled as function calls and sometimes as
inlined functions (the normal mode of compilation inlines them).

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/org.el b/lisp/org.el
index 2bfca4e..c679c5d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -137,9 +137,6 @@ (defvar org-heading-regexp "^\\(\\*+\\)\\(?: +\\(.*?\\)\\)?[ \t]*$"
 (declare-function org-table-maybe-eval-formula "org-table" ())
 (declare-function org-table-maybe-recalculate-line "org-table" ())
 
-(autoload 'org-element-at-point "org-element")
-(autoload 'org-element-type "org-element")
-
 (declare-function org-element--parse-objects "org-element"
                  (beg end acc restriction))
 (declare-function org-element-at-point "org-element" (&optional keep-trail))
@@ -152,6 +149,7 @@ (defvar org-heading-regexp "^\\(\\*+\\)\\(?: +\\(.*?\\)\\)?[ \t]*$"
 (declare-function org-element-nested-p "org-element" (elem-a elem-b))
 (declare-function org-element-parse-buffer "org-element"
                  (&optional granularity visible-only))
+(declare-function org-element-type "org-element" (element))
 (declare-function org-element-property "org-element" (property element))
 (declare-function org-element-put-property "org-element"
                  (element property value))
--8<---------------cut here---------------end--------------->8---

If instead you really want them always replaced with the definition of
the defsubst (on the assumption that this is indeed faster than a
function call or permits better optimization by the bytecompiler), then
these would need to be moved to org.el and their declarations removed.
Alternatively the defsubsts could go into a separate file that is then
required from both org.el and org-element.el None of these options solve
the larger problem of the circular dependencies.


PS:
If compiled single, four Babel tests fail; three of them with an
"(invalid-function org-export-with-buffer-copy)".  The function it
complains about is actually a macro in ox.el that is used in
org-export-as before its definition.  Not cool, it must be moved before
org-export-as.  The tests then pass with a single-compiled version of
org.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

  parent reply	other threads:[~2013-02-10 10:44 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-03 19:00 [ANN] Merge of new export framework on Wednesday Nicolas Goaziou
2013-02-03 20:59 ` François Allisson
2013-02-04  9:17 ` Detlef Steuer
2013-02-04 13:49   ` David Bjergaard
2013-02-04 21:56     ` Suvayu Ali
2013-02-05  1:07       ` Eric S Fraga
2013-02-05  7:41         ` Suvayu Ali
2013-02-05  9:25           ` Eric S Fraga
2013-02-05 11:18             ` Suvayu Ali
2013-02-05 12:50               ` Eric S Fraga
2013-02-05 13:07                 ` Suvayu Ali
2013-03-04 15:20                   ` Suvayu Ali
2013-02-04 23:05   ` Bastien
2013-02-04 13:35 ` Rasmus
2013-02-05 16:30 ` org export Taskjuggler (was: Re: [ANN] Merge of new export framework on Wednesday - ) Giovanni Ridolfi
2013-02-05 17:59   ` org export Taskjuggler Nicolas Goaziou
2013-02-07 10:21     ` Christian Egli
2013-02-07 10:43       ` Jambunathan K
2013-02-07 13:13       ` Nicolas Goaziou
2013-02-07  0:14 ` [ANN] Merge of new export framework on Wednesday Jay Kerns
2013-02-08 15:53 ` Sean O'Halpin
2013-02-08 16:45   ` Sebastien Vauban
2013-02-09 13:20     ` Sean O'Halpin
2013-02-09 13:56       ` Nicolas Goaziou
2013-02-09 18:14         ` Sean O'Halpin
2013-02-09 18:49           ` Nicolas Goaziou
2013-02-09 20:55             ` Nicolas Richard
2013-03-02 18:14   ` Bastien
2013-03-02 21:11     ` Sebastien Vauban
2013-03-03  5:35       ` Bastien
2013-03-03 12:25     ` Sean O'Halpin
2013-03-03 17:09       ` Bastien
2013-03-04  1:50     ` Rick Frankel
2013-03-04  6:57       ` Bastien
2013-03-04  9:09       ` T.F. Torrey
2013-03-04 15:19     ` Mike McLean
2013-03-04 15:24       ` Nicolas Goaziou
2013-03-04 16:12         ` Mike McLean
2013-03-04 16:30           ` Nicolas Goaziou
2013-03-04 16:44             ` Mike McLean
2013-03-04 15:28     ` Suvayu Ali
2013-03-04 17:44       ` Bastien
2013-02-09  8:03 ` Achim Gratz
2013-02-09  8:21   ` Nicolas Goaziou
2013-02-09  9:26   ` Bastien
2013-02-09 10:33     ` Achim Gratz
2013-02-09 10:44       ` Nicolas Goaziou
2013-02-09 10:49         ` Bastien
2013-02-09 15:01   ` Jambunathan K
2013-02-09 17:16   ` compilation issues of new export framework Achim Gratz
2013-02-09 17:50     ` Nicolas Goaziou
2013-02-09 18:02       ` Achim Gratz
2013-02-10 10:44       ` Achim Gratz [this message]
2013-02-10 12:53         ` Nicolas Goaziou
2013-02-10 15:53           ` Nicolas Goaziou
2013-02-11  7:49             ` Achim Gratz
2013-02-11 20:18               ` Nicolas Goaziou
2013-02-11 20:30                 ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txpko3cr.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).