From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Feature Request. org-bibtex-tags-are-keywords inherit tags Date: Fri, 18 Apr 2014 13:14:23 +0200 Message-ID: <87tx9qj3e8.fsf@bzg.ath.cx> References: <8761m89go7.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wb6ke-0007Pc-3i for emacs-orgmode@gnu.org; Fri, 18 Apr 2014 07:14:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wb6kV-0006rk-2I for emacs-orgmode@gnu.org; Fri, 18 Apr 2014 07:14:36 -0400 Received: from mail-we0-x231.google.com ([2a00:1450:400c:c03::231]:58614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wb6kU-0006rc-RF for emacs-orgmode@gnu.org; Fri, 18 Apr 2014 07:14:26 -0400 Received: by mail-we0-f177.google.com with SMTP id u57so1424637wes.8 for ; Fri, 18 Apr 2014 04:14:26 -0700 (PDT) In-Reply-To: (Leonard Randall's message of "Fri, 18 Apr 2014 10:02:10 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Leonard Randall Cc: emacs-orgmode@gnu.org Hi Leonard, thanks for starting this! A few stylistic comments inline. Leonard Randall writes: > diff --git a/lisp/org-bibtex.el b/lisp/org-bibtex.el > index ed645e5..848d0e4 100644 > --- a/lisp/org-bibtex.el > +++ b/lisp/org-bibtex.el > @@ -270,20 +270,31 @@ with underscores, and characters that are not permitted in org > tags will be removed. > > If t, local tags in an org entry will be exported as a > -comma-separated string of keywords when exported to bibtex. Tags > -defined in `org-bibtex-tags' or `org-bibtex-no-export-tags' will > -not be exported." > +comma-separated string of keywords when exported to bibtex. If Make sure to end sentences with two spaces. > (defcustom org-bibtex-no-export-tags nil > "List of tag(s) that should not be converted to keywords. > -This variable is relevant only if `org-bibtex-export-tags-as-keywords' is t." > +This variable is relevant only if `org-bibtex-tags-are-keywords' is t." > :group 'org-bibtex > :version "24.1" > :type '(repeat :tag "Tag" (string))) I fixed this docstring from the maint branch, you may need to pull again and rewrite your changes. > +(defcustom org-bibtex-inherit-tags nil > + "This variable controlls whether inherited tags are included The first line of the docstring should be a sentence. > +when converting org tags to bibtex keywords. It is relevant only > +if `org-bibtex-tags-are-keywords' is t. Tag inheritence itself is > +controlled by `org-use-tag-inheritence' and > +`org-exclude-tags-from-inheritence'" There is a missing fullstop at the end, and missing double-space between sentences. > + :group 'org-bibtex > + :version "24.1" > + :type 'boolean) Use :version "25.1" :package-version '(Org . "8.3") here, so that users will know the option is new in Org 8.3 (the next version that will be released from the master branc) and in Emacs 25.1 (the next Emacs stable version that will contain 8.3.) Otherwise, the patch looks good. Please resubmit it from a fresh pull with the modifications I suggested. Thanks in advance! -- Bastien