From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thorsten Jolitz <tjolitz@gmail.com>
Subject: Re: org-review-schedule
Date: Sat, 26 Apr 2014 12:38:11 +0200
Message-ID: <87tx9gjrzg.fsf@gmail.com>
References: <m2ppke1izt.fsf@polytechnique.org> <877g6leltk.fsf@bzg.ath.cx>
	<m2iopzdjyx.fsf@polytechnique.org> <87fvl1lx50.fsf@gmail.com>
	<m21twkbh8b.fsf@polytechnique.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43814)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1We006-0000Ii-GW
	for emacs-orgmode@gnu.org; Sat, 26 Apr 2014 06:38:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1We000-0003bk-95
	for emacs-orgmode@gnu.org; Sat, 26 Apr 2014 06:38:30 -0400
Received: from plane.gmane.org ([80.91.229.3]:41805)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1We000-0003bY-2R
	for emacs-orgmode@gnu.org; Sat, 26 Apr 2014 06:38:24 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1Wdzzz-0008HB-9B
	for emacs-orgmode@gnu.org; Sat, 26 Apr 2014 12:38:23 +0200
Received: from e178191243.adsl.alicedsl.de ([85.178.191.243])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Sat, 26 Apr 2014 12:38:23 +0200
Received: from tjolitz by e178191243.adsl.alicedsl.de with local (Gmexim 0.1
	(Debian)) id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Sat, 26 Apr 2014 12:38:23 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Alan Schmitt <alan.schmitt@polytechnique.org> writes:

> Hi Nicolas,
>
> I've changed all of these, and I will keep testing it over the next few
> days. I have one question remaining, though.
>
> On 2014-04-25 08:51, Nicolas Goaziou <n.goaziou@gmail.com> writes:
>
>>>         (if (time-less-p nt (current-time)) nt)))))
>>
>> This is a matter of taste, but I find one-armed `if' a bit confusing.
>> Since return value matters, I suggest to use
>>
>>   (and (time-less-p nt (current-time)) nt)
>
> Why not use "(when (time-less-p nt (current-time)) nt)" instead of "and"
> here?

the answer is in the quote already:

,---------------------------------------------
| Since return value matters, I suggest to use ...
`---------------------------------------------

-- 
cheers,
Thorsten