From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Patch for testing `org-open-at-point' Date: Tue, 03 Jun 2014 09:22:56 +0200 Message-ID: <87tx83ul96.fsf@bzg.ath.cx> References: <878urc0zmw.fsf@bzg.ath.cx> <874n1ryeq1.fsf@bzg.ath.cx> <87y4xgxu74.fsf@Rainer.invalid> <87r438uycj.fsf@bzg.ath.cx> <87vbsjunua.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wrj4M-0003ue-EI for emacs-orgmode@gnu.org; Tue, 03 Jun 2014 03:23:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wrj4H-0005WQ-2e for emacs-orgmode@gnu.org; Tue, 03 Jun 2014 03:23:38 -0400 Received: from mail-s76.mailgun.info ([184.173.153.204]:56743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wrj4G-0005WF-TN for emacs-orgmode@gnu.org; Tue, 03 Jun 2014 03:23:33 -0400 In-Reply-To: <87vbsjunua.fsf@Rainer.invalid> (Achim Gratz's message of "Mon, 02 Jun 2014 21:13:17 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Hi Achim, Achim Gratz writes: > Bastien writes: >> Achim Gratz writes: >>> Shouldn't the test check that the desired target is actually >>> reached? >> >> That would be too complicated. Checking that `org-open-at-point' >> does not throw an error is enough IMO. > > I don't think so. Implemented a check for that in 8e72c8fcfa. Okay, thanks. I pushed a small update, separating tests where we test that `org-open-at-point' correctly opens the link at point, and tests where we only tests that it correctly runs in a specific context. -- Bastien