From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] Fix massive slowdown in org-id-find
Date: Tue, 31 Mar 2015 12:01:36 +0200
Message-ID: <87twx1zdrz.fsf@nicolasgoaziou.fr>
References: <87bnjj2565.fsf@sophokles.streitblatt.de>
	<87vbhrnz07.fsf@nicolasgoaziou.fr>
	<877fu6u03n.fsf@sophokles.streitblatt.de>
	<87twxarox9.fsf@sophokles.streitblatt.de>
	<877fu5mdng.fsf@nicolasgoaziou.fr>
	<877ftydxn2.fsf@sophokles.streitblatt.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45409)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YcsyB-0006f8-Il
	for emacs-orgmode@gnu.org; Tue, 31 Mar 2015 06:00:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Ycsy5-0003BL-ML
	for emacs-orgmode@gnu.org; Tue, 31 Mar 2015 06:00:27 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:53881)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Ycsy5-0003Ai-HP
	for emacs-orgmode@gnu.org; Tue, 31 Mar 2015 06:00:21 -0400
In-Reply-To: <877ftydxn2.fsf@sophokles.streitblatt.de> (Florian Beck's message
	of "Mon, 30 Mar 2015 22:43:29 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Florian Beck <fb@miszellen.de>
Cc: emacs-orgmode@gnu.org

Florian Beck <fb@miszellen.de> writes:

> Seems like this does trick. I don't really understand why, though.The
> previous profiling seemed to indicate that most of the time was spent in
> `org-entry-get' (that's why I removed it).

`org-entry-get' is quite fast by itself. However it was called on every
entry with an :ID: property, which seems to include a lot of candidates
in your setup. Now it also requires :ID: value to match the one you're
looking for.

> I attached the new patch.

Applied. Thank you.

I added TINYCHANGE at the end of the commit message since you don't seem
to have signed the FSF papers. Please correct me if I'm wrong.

Regards,