From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Ecay <aaronecay@gmail.com>
Subject: Re: [PATCH][BUG] org-babel-confirm-evaluate
Date: Sat, 07 Nov 2015 10:48:30 +0000
Message-ID: <87twoyt79d.fsf@gmail.com>
References: <alpine.OSX.2.20.1511061604510.2161@charles-berrys-macbook.local>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52367)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1Zv12x-0000QN-R7
	for emacs-orgmode@gnu.org; Sat, 07 Nov 2015 05:48:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1Zv12u-0006Xd-LX
	for emacs-orgmode@gnu.org; Sat, 07 Nov 2015 05:48:35 -0500
Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:32870)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1Zv12u-0006XW-FF
	for emacs-orgmode@gnu.org; Sat, 07 Nov 2015 05:48:32 -0500
Received: by wmec201 with SMTP id c201so36863097wme.0
	for <emacs-orgmode@gnu.org>; Sat, 07 Nov 2015 02:48:32 -0800 (PST)
In-Reply-To: <alpine.OSX.2.20.1511061604510.2161@charles-berrys-macbook.local>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: "Charles C. Berry" <ccberry@ucsd.edu>, Org-Mode mailing list <emacs-orgmode@gnu.org>

Hi Chuck,

The patch is fundamentally correct, please push it.  A couple minor
comments:

2015ko azaroak 7an, "Charles C. Berry"-ek idatzi zuen:

[...]

> +      (`query (or
> +	       (and (not (org-bound-and-true-p
> +			  org-babel-confirm-evaluate-answer-no))
> +		    (yes-or-no-p
> +		     (format "Evaluate this %s code block%s on your system? "
                                                          ^^^
Rather than inserting that space, you should make the no-name value of
name-string a single space.  Otherwise there will be two spaces if the
block does have a name.

> +			     lang name-string)))
> +	       (and
> +		(message "Evaluation of this %s code-block%s is aborted."
> +			 lang name-string)
> +		nil)))

I think =E2=80=98progn=E2=80=99 would be better than =E2=80=98and=E2=80=99 =
here, just as a matter of
style.  Same comment as above applies about the extra space.

Thanks very much for the patch, and sorry for the breakage,
Aaron

PS Git gave me some strange errors about trailing whitespace when trying
to apply your patch, until I converted it from DOS to Unix line
endings.  I=E2=80=99ve never seen git do that before =E2=80=93 I think it u=
sually copes
very well with different line ending styles.  Does anyone know what to
do in this scenario?  Manually changing the line endings of the patch
file seems hackish.

--=20
Aaron Ecay