From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Moving from org-mode 6.33/7.9.3 to 8.3.2
Date: Sun, 29 Nov 2015 22:43:37 +0100
Message-ID: <87two4lbw6.fsf@nicolasgoaziou.fr>
References: <CAD9K4eBhshUNjL8t-cbRM4F8RgyGO3cO8uNYash3QbLoMexsOw@mail.gmail.com>
	<CA+M2ft-wq8Pt5Zi2XV8zQzLLWiUHX-HjRLprXrrrLpJZaYkeBA@mail.gmail.com>
	<CAD9K4eCt9Gha63gaWagEsihPSJzttE5aBh_BFV0aoG0DXPs--A@mail.gmail.com>
	<CA+M2ft9ApGTz8ogGaCxCfejAnhWW2Hwuj1X7ZwWg_VvMkmzAmA@mail.gmail.com>
	<CAD9K4eAX8Z9qHtu1+mqi7GCv=SAfYTkMcc2oCNe==9T=grixBw@mail.gmail.com>
	<CAD9K4eD-vEV1yWDg68NxTy7caXY6C1jvYcEaWVBWQdGjd667oA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40729)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1a39jB-0007wa-9B
	for emacs-orgmode@gnu.org; Sun, 29 Nov 2015 16:41:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1a39jA-0000mX-E5
	for emacs-orgmode@gnu.org; Sun, 29 Nov 2015 16:41:49 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:54066)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1a39jA-0000mT-71
	for emacs-orgmode@gnu.org; Sun, 29 Nov 2015 16:41:48 -0500
In-Reply-To: <CAD9K4eD-vEV1yWDg68NxTy7caXY6C1jvYcEaWVBWQdGjd667oA@mail.gmail.com>
	(Steve Moreau's message of "Sun, 29 Nov 2015 15:44:55 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Steve Moreau <moreau.steve@free.fr>
Cc: emacs-orgmode@gnu.org

Hello,

Steve Moreau <moreau.steve@free.fr> writes:

> Indeed, the org-setup-filling was concerned.
>
> *Before:*
>
>       (append fill-nobreak-predicate
>           '(org-fill-paragraph-separate-nobreak-p
>             ...
>
> (defvar org-element-paragraph-separate) ; org-element.el
> (defun org-fill-paragraph-separate-nobreak-p ()
>   "Non-nil when a new line at point would end current paragraph."
>   (looking-at (substring org-element-paragraph-separate 1)))
>
> *After:*
>
> 'org-fill-paragraph-separate-nobreak-p' predicate removed and the previous
> function has been deleted
>
> The following code has been added:
>
>   (let ((paragraph-ending (substring org-element-paragraph-separate 1)))
>     (org-set-local 'paragraph-start paragraph-ending)
>     (org-set-local 'paragraph-separate paragraph-ending))
>
>
> Could someone explain to me why the function has been removed?

It was removed because `org-element-paragraph-separate' is not enough to
find the boundaries of a paragraph, e.g.,

  - item1
  - item2
  This is a new paragraph

It is usually not a problem except for `fill-region', as you noticed.
However, I do not know how to plug our own functions into `fill-region'.

We could replace `fill-region' with `org-fill-region', tho.


Regards,

-- 
Nicolas Goaziou