emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Steve Moreau <moreau.steve@free.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: Moving from org-mode 6.33/7.9.3 to 8.3.2
Date: Sun, 29 Nov 2015 22:43:37 +0100	[thread overview]
Message-ID: <87two4lbw6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAD9K4eD-vEV1yWDg68NxTy7caXY6C1jvYcEaWVBWQdGjd667oA@mail.gmail.com> (Steve Moreau's message of "Sun, 29 Nov 2015 15:44:55 +0100")

Hello,

Steve Moreau <moreau.steve@free.fr> writes:

> Indeed, the org-setup-filling was concerned.
>
> *Before:*
>
>       (append fill-nobreak-predicate
>           '(org-fill-paragraph-separate-nobreak-p
>             ...
>
> (defvar org-element-paragraph-separate) ; org-element.el
> (defun org-fill-paragraph-separate-nobreak-p ()
>   "Non-nil when a new line at point would end current paragraph."
>   (looking-at (substring org-element-paragraph-separate 1)))
>
> *After:*
>
> 'org-fill-paragraph-separate-nobreak-p' predicate removed and the previous
> function has been deleted
>
> The following code has been added:
>
>   (let ((paragraph-ending (substring org-element-paragraph-separate 1)))
>     (org-set-local 'paragraph-start paragraph-ending)
>     (org-set-local 'paragraph-separate paragraph-ending))
>
>
> Could someone explain to me why the function has been removed?

It was removed because `org-element-paragraph-separate' is not enough to
find the boundaries of a paragraph, e.g.,

  - item1
  - item2
  This is a new paragraph

It is usually not a problem except for `fill-region', as you noticed.
However, I do not know how to plug our own functions into `fill-region'.

We could replace `fill-region' with `org-fill-region', tho.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2015-11-29 21:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27 16:56 Moving from org-mode 6.33/7.9.3 to 8.3.2 Steve Moreau
2015-11-27 17:32 ` John Hendy
2015-11-27 18:13   ` John Hendy
     [not found]   ` <CAD9K4eCt9Gha63gaWagEsihPSJzttE5aBh_BFV0aoG0DXPs--A@mail.gmail.com>
     [not found]     ` <CA+M2ft9ApGTz8ogGaCxCfejAnhWW2Hwuj1X7ZwWg_VvMkmzAmA@mail.gmail.com>
2015-11-28 17:15       ` Steve Moreau
2015-11-29 14:44         ` Steve Moreau
2015-11-29 21:43           ` Nicolas Goaziou [this message]
2015-11-30  7:05             ` Steve Moreau
2015-11-30 14:53               ` Nicolas Goaziou
2015-12-01  7:33                 ` Steve Moreau
2015-12-01 19:09                   ` Samuel Wales
2015-12-01 22:31                   ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87two4lbw6.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=moreau.steve@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).