From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] Fix the single quote printed in the message printed by
 org-table-edit-formulas
Date: Thu, 10 Mar 2016 10:25:33 +0100
Message-ID: <87twkelm5u.fsf@nicolasgoaziou.fr>
References: <CAFyQvY2GcivLbGTjhAA3JoMFPxfaE0==0t2TwFkxA40ULs+DZQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51844)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1adwoj-0006WI-Tr
	for emacs-orgmode@gnu.org; Thu, 10 Mar 2016 04:23:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1adwog-0007Ao-4r
	for emacs-orgmode@gnu.org; Thu, 10 Mar 2016 04:23:37 -0500
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:33260)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1adwof-0007Ak-VD
	for emacs-orgmode@gnu.org; Thu, 10 Mar 2016 04:23:34 -0500
In-Reply-To: <CAFyQvY2GcivLbGTjhAA3JoMFPxfaE0==0t2TwFkxA40ULs+DZQ@mail.gmail.com>
	(Kaushal Modi's message of "Wed, 9 Mar 2016 11:18:17 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>

Hello,

Kaushal Modi <kaushal.modi@gmail.com> writes:

> Can someone please review and commit this patch.
>
> It basically prints the "C-c '" binding correctly in the echo area, using
> straight quote instead of curly quote (matters in emacs 25.x). The details
> are in the commit log below.

Thank you for the patch.

> Fix the quote style when in the "C-c '" key-binding that is printed in the
> echo via the substitute-command-keys function. In emacs 25.x, a straight
> quote is rendered as a right-curly quote by default.

Shouldn't this be handled by `substitute-command-keys' already? The fix
looks like a hack.

> -      (message
> +      (message "%s"
>          (substitute-command-keys "\\<org-mode-map>\
>  Edit formulas, finish with `\\[org-ctrl-c-ctrl-c]' or
> `\\[org-edit-special]'.  \
>  See menu for more commands.")))))

Shouldn't ` and ' also be dropped around \\[command]?

Regards,

-- 
Nicolas Goaziou