emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH 1/2] org-agenda.el: Fix `org-agenda-bulk-custom-functions' supported Customize type
@ 2016-05-11 22:00 Phil Hudson
  2016-05-13 16:03 ` Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: Phil Hudson @ 2016-05-11 22:00 UTC (permalink / raw)
  To: emacs-orgmode


From 256cf1f854e902de392a325ec4b9c8204fb84a21 Mon Sep 17 00:00:00 2001
From: Phil Hudson <phil.hudson@iname.com>
Date: Wed, 11 May 2016 15:34:12 +0100
Subject: [PATCH 1/2] org-agenda.el: Fix `org-agenda-bulk-custom-functions'
 supported Customize type

* org-agenda.el (`org-agenda-bulk-custom-functions'): Change the defcustom
  template to recognize that the code expects this alist's elements to be
  two-element lists like (?a b), not conses like (?a . b).  The Customize UI
  previously incorrectly presented the latter.  When saved, this led to the
  agenda bulk-commands menu correctly presenting the accelerator key 'a' but
  then erroring when it tried to execute the associated command 'b'.
---
 lisp/org-agenda.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index ef41678..ab280fb 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -2008,7 +2008,7 @@ For example, this value makes those two functions available:
 With selected entries in an agenda buffer, `B R' will call
 the custom function `set-category' on the selected entries.
 Note that functions in this alist don't need to be quoted."
-  :type 'alist
+  :type '(alist :key-type character :value-type (group function))
   :version "24.1"
   :group 'org-agenda)
 
-- 
2.8.0.rc3


-- 
Phil Hudson                   http://hudson-it.ddns.net
@UWascalWabbit                 PGP/GnuPG ID: 0x887DCA63

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2] org-agenda.el: Fix `org-agenda-bulk-custom-functions' supported Customize type
  2016-05-11 22:00 [PATCH 1/2] org-agenda.el: Fix `org-agenda-bulk-custom-functions' supported Customize type Phil Hudson
@ 2016-05-13 16:03 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2016-05-13 16:03 UTC (permalink / raw)
  To: Phil Hudson; +Cc: emacs-orgmode

Hello,

Phil Hudson <phil.hudson@iname.com> writes:

> From 256cf1f854e902de392a325ec4b9c8204fb84a21 Mon Sep 17 00:00:00 2001
> From: Phil Hudson <phil.hudson@iname.com>
> Date: Wed, 11 May 2016 15:34:12 +0100
> Subject: [PATCH 1/2] org-agenda.el: Fix `org-agenda-bulk-custom-functions'
>  supported Customize type

This patch was already applied a few days ago.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-13 16:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-11 22:00 [PATCH 1/2] org-agenda.el: Fix `org-agenda-bulk-custom-functions' supported Customize type Phil Hudson
2016-05-13 16:03 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).