From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: babel link bug
Date: Sat, 08 Feb 2020 09:17:43 +0100
Message-ID: <87tv41ze54.fsf@nicolasgoaziou.fr>
References: <87r1z5y20z.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:50614)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1j0LJQ-0007XN-9A
 for emacs-orgmode@gnu.org; Sat, 08 Feb 2020 03:18:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1j0LJO-0006s9-T7
 for emacs-orgmode@gnu.org; Sat, 08 Feb 2020 03:17:59 -0500
Received: from relay10.mail.gandi.net ([217.70.178.230]:47053)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
 id 1j0LJO-0006r2-NX
 for emacs-orgmode@gnu.org; Sat, 08 Feb 2020 03:17:58 -0500
In-Reply-To: <87r1z5y20z.fsf@gmail.com> (Matt Huszagh's message of "Fri, 07
 Feb 2020 23:24:44 -0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Matt Huszagh <huszaghmatt@gmail.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Hello,

Matt Huszagh <huszaghmatt@gmail.com> writes:

> -	      (let ((file (and (member "file" result-params)
> -			       (cdr (assq :file params)))))
> +	      (let ((file (cdr (assq :file params))))

This patch is wrong, with it, :file parameter alone would imply file
result, which is not sufficient. See commit
26ed66b23335eb389f1f2859e409f46f66279e15

"link" format is only meant to be used with "file" output.

Regards,

-- 
Nicolas Goaziou