From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Subject: Re: Possible to exclude/include tags for agenda custom commands?
Date: Mon, 24 Feb 2020 09:03:27 -0800
Message-ID: <87tv3fx6hs.fsf@ericabrahamsen.net>
References: <m27e0riq65.fsf@brautaset.org> <8736bfxwu0.fsf@bzg.fr>
 <m2y2t6gttl.fsf@brautaset.org> <874kvl8aoc.fsf@ericabrahamsen.net>
 <87d0a99nph.fsf@gnu.org> <87v9o16tga.fsf@ericabrahamsen.net>
 <87mu9d6q0m.fsf@ericabrahamsen.net> <87imk12i19.fsf@gnu.org>
 <878skxavgf.fsf@ericabrahamsen.net> <87mu994ete.fsf@gnu.org>
 <87ftf1xbtu.fsf@ericabrahamsen.net> <87d0a4xs79.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:47060)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <geo-emacs-orgmode@m.gmane-mx.org>)
 id 1j6H8s-0003PU-M2
 for emacs-orgmode@gnu.org; Mon, 24 Feb 2020 12:03:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <geo-emacs-orgmode@m.gmane-mx.org>)
 id 1j6H8q-0005oE-Kx
 for emacs-orgmode@gnu.org; Mon, 24 Feb 2020 12:03:38 -0500
Received: from ciao.gmane.io ([159.69.161.202]:37808)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <geo-emacs-orgmode@m.gmane-mx.org>)
 id 1j6H8q-0005n9-ET
 for emacs-orgmode@gnu.org; Mon, 24 Feb 2020 12:03:36 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <geo-emacs-orgmode@m.gmane-mx.org>)
 id 1j6H8o-000L3c-Ee
 for emacs-orgmode@gnu.org; Mon, 24 Feb 2020 18:03:34 +0100
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: emacs-orgmode@gnu.org

Bastien <bzg@gnu.org> writes:

> Hi Eric,
>
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> The key is having `org-agenda-sticky' set to t -- this means that we'll
>> let-bind buffer-local variables in a buffer where they're already
>> set.
>
> thanks for the reproducible example, I was able to get the warning.
>
> You can safely ignore it: when redoing sticky agenda, we need to
> let-bind the values as explicitely set in the agenda custom command
> (here the org-agenda-tag-filter value) while preparing the agenda
> requires the variables to be made local.  I don't see what can be
> done and I don't think there hidden bugs lingering around here.

Okay! I also didn't think anything terrible was going on here. I note
there's the variable `org-agenda-doing-sticky-redo' that we could
presumably check, and avoid re-setting the tag filter when it's t, but
again I don't think the warning is a big deal.

Thanks,
Eric