From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Kamm Subject: Re: Bug or not a bug? dot expansion in ob-shell Date: Sun, 01 Mar 2020 07:46:38 -0800 Message-ID: <87tv38dqn5.fsf@gmail.com> References: <87r1yq4xiz.fsf@gnu.org> <875zg2kcy0.fsf@ucl.ac.uk> <87h7zmiw0v.fsf@gmail.com> <871rqqag19.fsf@bzg.fr> <87wo8iitzz.fsf@ucl.ac.uk> <87ftf63d79.fsf@gnu.org> <87pnear7tl.fsf@ucl.ac.uk> <87v9o236v1.fsf@gnu.org> <8736b66z6t.fsf@gnu.org> <877e0h571l.fsf@alphaville.usersys.redhat.com> <878skwbc3g.fsf@bzg.fr> <8736b36492.fsf@alphaville.usersys.redhat.com> <87imjyoi99.fsf@gnu.org> <87y2slqudr.fsf@gmail.com> <87y2sltnas.fsf@gmail.com> <87d09wd8c5.fsf@gmail.com> <87wo84ehvx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:48771) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8Qou-0002Pr-Oh for emacs-orgmode@gnu.org; Sun, 01 Mar 2020 10:47:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8Qot-0006gZ-Mn for emacs-orgmode@gnu.org; Sun, 01 Mar 2020 10:47:56 -0500 In-Reply-To: <87wo84ehvx.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Tom Gillespie Cc: Bastien , Nick Dokos , emacs-orgmode@gnu.org As someone who doesn't really use ob-shell, I've made too much noise in this thread, and am intending this to be my last comment here... I think it's a bad idea that ":results value", and not specifying ":results", give different behavior. In my own Org-babel files, I usually have a header line like follows: #+PROPERTY: header-args :results output Which sets the default return value to ":results output". Then, I manually specify ":results value" when I need that instead. But if explicitly writing ":results value" is different than the default, then it would no longer be possible to use this pattern anymore. I think it would be prudent to revert the change to ":results value" before the release of 9.4. I think Tom makes a convincing case that returning the exit code is not only wrong, but also disruptive to existing users of ob-shell.