From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4EQYLAvPUV8VbgAA0tVLHw (envelope-from ) for ; Fri, 04 Sep 2020 05:22:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WFLsJwvPUV9YEwAAB5/wlQ (envelope-from ) for ; Fri, 04 Sep 2020 05:22:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CA5E094066A for ; Fri, 4 Sep 2020 05:22:18 +0000 (UTC) Received: from localhost ([::1]:38400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE4Az-0007WH-EU for larch@yhetil.org; Fri, 04 Sep 2020 01:22:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kE4AW-0007W3-Lr for emacs-orgmode@gnu.org; Fri, 04 Sep 2020 01:21:48 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:57747) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kE4AU-0007n2-2o for emacs-orgmode@gnu.org; Fri, 04 Sep 2020 01:21:47 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 84DE17896E; Fri, 4 Sep 2020 01:21:44 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=NZxEAUpnFGOaY1knErlROhvjTxE=; b=fOLXzJ VL4g5EZ09JBvDNaFPs9LRDxjyfhrGc3/l5zqwMeckRDxmqxiAtXjOjFRpj51zHYb 6Rlz8m5pmpTF1+BVKueUSn81kwarxx0LInrlAdp/r2+iL0nDXf9Mj7ToRTf2OuA8 80V5jHOrWOY1Jx0jR3fG8yl9roUoHTVFCupYo= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 7C0BD7896D; Fri, 4 Sep 2020 01:21:44 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=k3tbWkzzUEIWzJIClHATEyQTpaIx/c0tpPt7Jc7O/n8=; b=eRjgaIEGGhQ1ffSxcniDc7vbwkBgqYS9cbFyM+3wIoibhLBYbMYqovaSMe/5T7NYCt3Aqr4YqzW6OwwHiMsrjRahdRS8yJIPYReEK0x5l/fGhk3vGmluyDvM9eYBNWV5xx4dLvJgdwqDMMJYYUlitB9RnqFQwrh3S4KXFFpjtZU= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 109DD7896C; Fri, 4 Sep 2020 01:21:44 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Matt Huszagh Subject: Re: [PATCH] Omit file description when :file-desc has nil value In-Reply-To: <87sgbzl6uy.fsf@gmail.com> References: <87sgbzl6uy.fsf@gmail.com> Date: Fri, 04 Sep 2020 01:21:43 -0400 Message-ID: <87tuwef76g.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 85712FC2-EE6E-11EA-B787-01D9BED8090B-24757444!pb-smtp1.pobox.com Received-SPF: pass client-ip=64.147.108.70; envelope-from=kyle@kyleam.com; helo=pb-smtp1.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/04 01:21:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "emacs-orgmode@gnu.org" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=pobox.com header.s=sasl header.b=fOLXzJ V; dkim=fail (rsa verify failed) header.d=kyleam.com header.s=mesmtp header.b=eRjgaIEG; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: hAd2S+8pj5px Matt Huszagh writes: > Hello, > > This patch omits a file description when :file-desc has a nil > value. Previously, the following src block > > #+BEGIN_SRC asymptote :results value file :file circle.pdf :file-desc :output-dir img/ > size(2cm); > draw(unitcircle); > #+END_SRC > > would yield > > #+RESULTS: > [[file:img/circle.pdf][circle.pdf]] > > This makes it impossible (I think) to provide :file-desc with a default > value and prevent the description in some cases. Hmm, I think that's unfortunately the case. > I feel I may be missing something in regard to why this previously had > the functionality it did. Is there a use case I've missed? A use case was given in the initial patch: . The test for this behavior mentioned there is test-ob/file-desc-header-argument. That thread links to another thread by gmane ID. That's this one: https://orgmode.org/list/87limm4eo2.fsf@med.uni-goettingen.de/T/#u > To me, the documentation seems to indicate that my patch is the > desired behavior: > > The =file-desc= header argument defines the description (see > [[*Link Format]]) for the link. If =file-desc= has no value, the > "description" part of the link will be omitted. > > Full disclaimer: I wrote this section of the documentation as part of > this patch: > > https://lists.gnu.org/archive/html/emacs-orgmode/2020-07/msg00320.html Right, to reflect the current behavior established as a result of the above thread, I think that should be reworded to distinguish between an absent :file-desc header and one with no argument. Sorry for not catching that when reviewing your initial patch.