emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Dmitrii Korobeinikov <dim1212k@gmail.com>
Cc: Marco Wahl <marcowahlsoft@gmail.com>,
	emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Preventing org-cycle from scrolling the buffer
Date: Sat, 05 Sep 2020 07:26:35 +0200	[thread overview]
Message-ID: <87tuwcaj5g.fsf@gnu.org> (raw)
In-Reply-To: <CA+Yh0STTE+Zx-zct3qy7eyqTovogr_fqwwOCLx9z3da7_hFRnw@mail.gmail.com> (Dmitrii Korobeinikov's message of "Fri, 3 Apr 2020 16:41:16 +0600")

Hi Dmitrii,

Dmitrii Korobeinikov <dim1212k@gmail.com> writes:

> Nice, I see!
>
>> IDK.  AFAICS you are right with your argumentation.  I don't see the
>> need of that feature, though, yet.  But that's just me.  I think you are
>> the best candidate to try an implementation of the feature.
>
> I have attached a small patch, seems to be working! Of course, if this
> is to be merged, that defvar will have to turn into a defcustom.

thanks for the patch, I applied a small variant of it as 056fc532b.

I don't think we need an option (defcustom) for this, the current
behavior seems correct -- but I'm convinced some people would prefer
the previous behavior.  If there are a lot of such people with strong
argument, perhaps we will have to revert the change.

Thanks,

-- 
 Bastien


  reply	other threads:[~2020-09-05  5:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19  7:49 Preventing org-cycle from scrolling the buffer Dmitrii Korobeinikov
2020-03-31 15:29 ` Marco Wahl
2020-04-03 10:41   ` Dmitrii Korobeinikov
2020-09-05  5:26     ` Bastien [this message]
2020-09-06 18:14       ` Dmitrii Korobeinikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuwcaj5g.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=dim1212k@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=marcowahlsoft@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).