From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oPoEH/0elF/6EgAA0tVLHw (envelope-from ) for ; Sat, 24 Oct 2020 12:33:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wGwXG/0elF/raAAA1q6Kng (envelope-from ) for ; Sat, 24 Oct 2020 12:33:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE7259404CC for ; Sat, 24 Oct 2020 12:33:00 +0000 (UTC) Received: from localhost ([::1]:41248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWIjD-0001Jn-HX for larch@yhetil.org; Sat, 24 Oct 2020 08:32:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWIgz-0001GP-P2 for emacs-orgmode@gnu.org; Sat, 24 Oct 2020 08:30:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46188) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWIgy-0000IT-Mw; Sat, 24 Oct 2020 08:30:41 -0400 Received: from lns-bzn-32-82-254-31-120.adsl.proxad.net ([82.254.31.120]:36968 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1kWIgw-0006vw-FF; Sat, 24 Oct 2020 08:30:40 -0400 Received: by guerry (Postfix, from userid 1000) id 4479E1A60E5B; Sat, 24 Oct 2020 14:30:36 +0200 (CEST) From: Bastien To: Matt Huszagh Subject: Re: [PATCH] babel latex headers and image generation commands Organization: GNU References: <874kw6ztr9.fsf@gmail.com> <871rrayrsc.fsf@gmail.com> <87y2thylcb.fsf@gmail.com> <87r1z29abl.fsf@gnu.org> <87y2lynft3.fsf@gmail.com> <87zh685bl4.fsf@gmail.com> <87d034qacb.fsf@gmail.com> <874kobmnrc.fsf@gnu.org> <87sgbqzqgr.fsf@gmail.com> Date: Sat, 24 Oct 2020 14:30:36 +0200 Message-ID: <87tuujhklv.fsf@bzg.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "emacs-orgmode@gnu.org" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: OZD17GUho23O Hi Matt, sorry for the delayed answer. Matt Huszagh writes: > Bastien writes: > >> Prefer >> >> * lisp/ob-latex.el (org-babel-latex-preamble): New option for LaTeX >> preamble customization. >> >> "New option" is quite standard, an "option" being a customizable >> variable. In this case, "New option" would probably be enough, given >> the name of the option is quite self-explanatory. Also, some find it >> pedantic, but "LaTeX" is the correct spelling in a changelog I guess. > > Fixed in new patch (attached). Applied as ae35a3459, thanks! >> The first line of the docstring should contain a sentence, so you'd >> need to have a new paragraph after "runtime to the LaTeX preamble." > > Also fixed. Making the first line a full sentence means that some lines > are a little longer than 80 characters. Is this acceptable? > >> What for users who don't have inkscape? > > This is just a default, but I could use a dvisvgm command as the default > instead? Either way, converting a PDF to SVG will require an executable > outside Emacs, but I guess dvisvgm is more likely to be installed for > people using a texlive installation. My personal preference for inkscape > is because it should handle all PDF inputs, whereas there are some cases > where dvisvgm may fail (see > https://github.com/mgieseki/dvisvgm/issues/139) due to changes in > ghostscript. Still, dvisvgm generally does a very good job with PDF > inputs. Let me know your thoughts, I'd be happy to set the default to a > dvisvgm command instead. Let's see what people think when they try it after 9.5. Can you provide a patch against etc/ORG-NEWS announce this? Thanks, -- Bastien