From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ENQCKLEroGAbzwAAgWs5BA (envelope-from ) for ; Sat, 15 May 2021 22:14:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QKmOI7EroGDdWgAAbx9fmQ (envelope-from ) for ; Sat, 15 May 2021 20:14:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 062052C96B for ; Sat, 15 May 2021 22:14:40 +0200 (CEST) Received: from localhost ([::1]:58062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1li0gJ-0002Ms-HM for larch@yhetil.org; Sat, 15 May 2021 16:14:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1li0fy-0002Mh-EP for emacs-orgmode@gnu.org; Sat, 15 May 2021 16:14:18 -0400 Received: from mout01.posteo.de ([185.67.36.65]:48977) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1li0fu-0004q2-U4 for emacs-orgmode@gnu.org; Sat, 15 May 2021 16:14:18 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id A5F4D240026 for ; Sat, 15 May 2021 22:14:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1621109651; bh=o1aQElxSdnuAIOpb2Z06lDsQMitsfGS9v6uaOYGg3hc=; h=From:To:Cc:Subject:Date:From; b=ZCNyxZkgirWfKC+dWnb0NxwbD1PNnuAUy1spNxi8nB437Zs4oHXhvpc9wsjPF7hLp SGytNW8I8qS7HDHcOuDgNg0p++2f/sj+pofdxFguUNhfvWYoXBhHdcjRXyVZpRWwiS fZOWpohyFhGGCaij/vkeOzTfyi7NefVhUGWBM6X7XWdVqzILQwzD5PLjNkpcqv8BEQ X4z9N+Zs8dG/Me5cfI/e2Jx6tg6UUybrpHmWM3BC59XvkvOdbjXiJIZVD1e1AxCpHn WMkH9cxrILBcq3ro2UyuH6GRA88XdaRgrWC8h4SiwsKz9Pf6+Gz/mxxr0NRGNMJTqW 8GaJLsf7xvX3Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FjGnZ5k5mz9rxL; Sat, 15 May 2021 22:14:10 +0200 (CEST) From: =?utf-8?Q?Juan_Manuel_Mac=C3=ADas?= To: Bastien Subject: Re: [PATCH] Possibility of using alternative separators in macros References: <87wnsjx5rs.fsf@posteo.net> <87r1id7cwb.fsf@ucl.ac.uk> <8735ut8d2c.fsf@posteo.net> <87im3prvz8.fsf@ucl.ac.uk> <87h7j95drf.fsf@posteo.net> <87v97kcegj.fsf@gnu.org> Date: Sat, 15 May 2021 20:14:09 +0000 In-Reply-To: <87v97kcegj.fsf@gnu.org> (Bastien's message of "Sat, 15 May 2021 15:29:48 +0200") Message-ID: <87tun33gby.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=maciaschain@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: orgmode , Eric S Fraga Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621109681; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=6m5cbkUGsdKFP8g1qRokYxdrJfJxGUZG8axBavuFLJM=; b=BabBBtQ/y8/8mGcf99QhYCFuJ/TRrFcoQ5OF+Ke9UbgTIa1yGHpe2uCUcOJVVus9eV7fqe H1nq+7qT98ry/OrFnClHEayYlLDasm5wOwFw3vjbplkCi92546ImV1AikzjljUJ8Lt9eYc 82gtdQqoOuW+YYnXk1zygznK8eLM/xLq4mROOTt2OQhfy5w7SrFKmWjma+z1UGa/eJZH8j uYB9IHjbp2aq1/Brv1OIR0iIcKo5Xi4MASguxLztPX7k1Pd4tYTTg5BdIRIJ3g2w/XNeBj mvdVoeJLt5oIMDHXRtWJkgr9HCLj/V4okj2j6N6XZ+pc8kDuhKhWOCT+FvMVBQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621109681; a=rsa-sha256; cv=none; b=RlFXxTmKezEESHU63RXX+mxlJkDb8VETobFj8iXkfPW5LyIzdvhNjGqgwpkk43En5J/Y/M 4CsTZiY0tW72B8kTq8e8PpoHfpdgCE9jb2IP/KlmH07bE9jK6Crs/R/yRadA7bXvQxY5DH PZeVpnoz9/BnvBWLxoFDa01OxWEYUTrDDoehme4Y1xNszPnh3/TR/iNapVZzq1pAbwQPhP 9aYWxo+ntgh3goDsE3iV0FfCL1QBXyI1bly+EmQ4ZCJogoaEnqcsgXAT5e6Dr0QBx1GVVJ mqSj7D6+8kClgHBTZGB9gLRJUnRnz7msv8MJ+bXON+fVk3OR8bCD3dmxtYzO5g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ZCNyxZkg; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.15 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ZCNyxZkg; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 062052C96B X-Spam-Score: -3.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: wddStpT34f6r Hi Bastien, Bastien writes: > I'll let Eric test and comment, but in the meantime, I'm just > noticing the patch breaks many tests in master. > > If Nicolas thinks this change is good and Eric validate the patch, > please prepare one with a commit message, updating the tests too. Ok, if necessary I will prepare an updated version of the patch, with the updated tests, and with a commit message (a thousand apologies for my continuous forgetting in commit messages...). I have noticed certain bugs in my patch, especially within org-element-macro-parser (a bad regexp and something else). That caused macros with a single argument to be incorrectly interpreted (and it also caused an error in one of the tests). If Eric (or someone else) wants an updated version of the patch I could send it him. Anyway, I admit that I have become somewhat skeptical about the usefulness of my patch. Perhaps, as a patch, it is too premature and perhaps it's better to leave the macros issue, for the moment, as it is... What do you think? Best regards, Juan Manuel