From: "Juan Manuel Macías" <maciaschain@posteo.net>
To: Bastien <bzg@gnu.org>
Cc: orgmode <emacs-orgmode@gnu.org>, Eric S Fraga <e.fraga@ucl.ac.uk>
Subject: Re: [PATCH] Possibility of using alternative separators in macros
Date: Sat, 15 May 2021 20:14:09 +0000 [thread overview]
Message-ID: <87tun33gby.fsf@posteo.net> (raw)
In-Reply-To: <87v97kcegj.fsf@gnu.org> (Bastien's message of "Sat, 15 May 2021 15:29:48 +0200")
Hi Bastien,
Bastien writes:
> I'll let Eric test and comment, but in the meantime, I'm just
> noticing the patch breaks many tests in master.
>
> If Nicolas thinks this change is good and Eric validate the patch,
> please prepare one with a commit message, updating the tests too.
Ok, if necessary I will prepare an updated version of the patch, with
the updated tests, and with a commit message (a thousand apologies for
my continuous forgetting in commit messages...).
I have noticed certain bugs in my patch, especially within
org-element-macro-parser (a bad regexp and something else). That caused
macros with a single argument to be incorrectly interpreted (and it also
caused an error in one of the tests). If Eric (or someone else) wants
an updated version of the patch I could send it him.
Anyway, I admit that I have become somewhat skeptical about the
usefulness of my patch. Perhaps, as a patch, it is too premature and
perhaps it's better to leave the macros issue, for the moment, as it
is... What do you think?
Best regards,
Juan Manuel
next prev parent reply other threads:[~2021-05-15 20:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 13:26 [PATCH] Possibility of using alternative separators in macros Juan Manuel Macías
2021-05-01 8:30 ` Bastien
2021-05-01 10:04 ` Nicolas Goaziou
2021-05-01 10:17 ` Bastien
2021-05-01 10:18 ` Bastien
2021-05-01 21:50 ` Juan Manuel Macías
2021-05-02 21:08 ` Christian Moe
2021-05-12 11:49 ` Maxim Nikulin
2021-05-16 19:21 ` Christian Moe
2021-05-17 17:03 ` Maxim Nikulin
2021-05-17 18:51 ` Christian Moe
2021-05-02 12:13 ` Eric S Fraga
2021-05-11 11:01 ` Eric S Fraga
2021-05-11 16:12 ` Juan Manuel Macías
[not found] ` <87im3prvz8.fsf@ucl.ac.uk>
2021-05-11 18:25 ` Juan Manuel Macías
2021-05-15 13:29 ` Bastien
2021-05-15 20:14 ` Juan Manuel Macías [this message]
2021-05-15 20:25 ` Bastien
2021-05-15 21:05 ` Juan Manuel Macías
2021-05-16 12:17 ` Bastien
2021-05-16 16:48 ` Maxim Nikulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tun33gby.fsf@posteo.net \
--to=maciaschain@posteo.net \
--cc=bzg@gnu.org \
--cc=e.fraga@ucl.ac.uk \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).