From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EBBkKx/k02JNoQAAbAwnHQ (envelope-from ) for ; Sun, 17 Jul 2022 12:27:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6Fk9Kx/k02Je4AAAauVa8A (envelope-from ) for ; Sun, 17 Jul 2022 12:27:43 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6225BE3DB for ; Sun, 17 Jul 2022 12:27:43 +0200 (CEST) Received: from localhost ([::1]:58132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oD1V0-00074U-K9 for larch@yhetil.org; Sun, 17 Jul 2022 06:27:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oD1TU-00072w-Ep for emacs-orgmode@gnu.org; Sun, 17 Jul 2022 06:26:08 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:38548) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oD1TQ-0005xZ-9o for emacs-orgmode@gnu.org; Sun, 17 Jul 2022 06:26:08 -0400 Received: by mail-pl1-x629.google.com with SMTP id k19so6719302pll.5 for ; Sun, 17 Jul 2022 03:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=YTtTUkxo45Rwq5eCStE9yvP1EAMXE21c27RGd1DUuMQ=; b=JBbks4Ju1FETznV/pJfkx1FKEvjtZXDEUeFzI3aOSupTHqx3iuqwXwNnobLa/7iTyL ejREWkezzBWVBA7bb2Kaof9B4SK9mPKLQZY+dBQb0VQhzVwO/qbJGEXtbW6t3yE4dlvT hVBTUUQPHh2fxqSalCB0Yw06SKks+3+h1UEXQh+3gTvk7sqLGTlrZmGX418z0QGwp7NZ KYy+NfNLs3N7iBBBP0Y91DQc/GNOEtlGr81jRKFNkv5667WYbYj85YiW6LLh3BLPJet8 /l7b9ObMjSrntkie3MBSyjScKUVkV6ANWSwzxbAXKMMHBjPJvzDN14yCyjJDUcKeycM0 hAZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=YTtTUkxo45Rwq5eCStE9yvP1EAMXE21c27RGd1DUuMQ=; b=HSrpGkjp7rVGP1103Tx/7o6LNlvOhBBlXsjecKynu4qEfGfLrnEPMp/OvpnJb3htm4 DdyMKq8IbUwEbzistZtC/RxvBuN1ZA79+c8AHZCwusE4mkb37e6z4fnC8nJG8C4lURgX CgpfQRo+7cuybOk8qsTl1ptM8hvMObA0ezFtHNPjfN9TWjOPXia6b7e9AMxGz3vD/Mks eTMkm6/pAmXcsT8rrlV4YJYF1+rhNx9Wbuy91irnwohKokqin0cpcBJfx05n0HnjLaVR kkT49A1Z/8ivPJIL7lmiZDQ72LEn7zIGHypU9chy9WRLt9V6N+/q/cyrb6wfMXmsTtf1 TXaA== X-Gm-Message-State: AJIora8pygXwtFEmevlJuCUUbCOodJ/Oc9n2/hYCkeOFlPQypBtPTaQJ ZrX7uG1KiCOHMR0hAvXTVpU= X-Google-Smtp-Source: AGRyM1uMwvi/7m82M3ZUxZ8sxem5sbh96KviR3QlYkAotkyFsh2wxx1WOmYbI5Ezy4K6YyKVDDvWfg== X-Received: by 2002:a17:90b:3cf:b0:1ef:8a69:9ad1 with SMTP id go15-20020a17090b03cf00b001ef8a699ad1mr25982912pjb.114.1658053562811; Sun, 17 Jul 2022 03:26:02 -0700 (PDT) Received: from localhost ([2409:8a70:2bd:4d0:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id t17-20020a170902e85100b0016357fd0fd1sm7015219plg.69.2022.07.17.03.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jul 2022 03:26:02 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Cc: Org Mode List , Hugo Heagren Subject: Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters In-Reply-To: References: <87zgl1npow.fsf@localhost> <20220405192931.6747-1-hugo@heagren.com> <87a6cx79xn.fsf@localhost> <87zgi6fckr.fsf@heagren.com> <871qvixhfw.fsf@gmail.com> <87v8s8n1bm.fsf@heagren.com> <87let39d3c.fsf@localhost> <877d4flu3x.fsf@heagren.com> <87cze5e84m.fsf@localhost> <87tu7gkb4l.fsf@heagren.com> Date: Sun, 17 Jul 2022 18:27:05 +0800 Message-ID: <87tu7g6nly.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=yantar92@gmail.com; helo=mail-pl1-x629.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658053663; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=YTtTUkxo45Rwq5eCStE9yvP1EAMXE21c27RGd1DUuMQ=; b=NCI/pD+cR0gG9Blcv/IuxlGpxjZePt2CvGggwm1hH10V7Oqjg5fFmvtIGNdw68V9AM2g9R iI+t5+qJ4Z3S4xmXW5Fw3x/2DH8YMQyog4oIJFEBMAH/eFHK/5mR5PlrLtssx4uVstRpZZ ztML65JF/liVOxlbF8XH5aH3ly+fifplQ4PUq6o7FwlXVuVdTT4b69PDmBzZZqz/DFAWex s3xUXemnNlT3wqXVsZCDWgqZjfHpgKhYZbR4IIk8zcgDSLrZDkEhr04xrV48LUg9pQIvKm 1Pb5TK+Ilg2klPko2xyhvyCE5xnVhtMAbRRh2SWhvvRED961NKyiYCsBbdmMeg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658053663; a=rsa-sha256; cv=none; b=TB06bbEdDgnrcnh+AywqyzQDL2NL55sNDFF+Daegn2glyzwhWOeqtEIGMzcOVdvoXg/5SX Hn1hY0WZwQk0FwqVQ2VGVx1jJNkL3BH1iMbZ32q5fOF7EWdMn+mGtQT5wFkIoKwzLNe7OQ VgC7X9skvUwexHZfgkbKSP5QT6jqeM45d6/AH0NGdcp9UtADdnnZf8z+ahnFaGqOs2rhEc 5Z1pYC8JR9vjb90y895061Q/Vt0Rnfe6piv0klKD/ehVx8h+AvAkiR2Ca7Wl7zOV57gWs1 aLsz3Fqw8dqzum7sR6hBWpvu+KBMtGNqazKx/1XoL26QiWZ23Yy2AO/6py1KnQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JBbks4Ju; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.43 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JBbks4Ju; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6225BE3DB X-Spam-Score: -5.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: gAR0KZtoDZrl Max Nikulin writes: > Ihor, Hugo raised a question how to interpret nil returned by > :insert-description functions. Do you have any opinion? I do not like > the idea to consider it as an error since string is expected. I would > prefer to call `org-link-make-description-function' as a fallback. > > On 17/07/2022 04:20, Hugo Heagren wrote: >>> Can you also update the documentation for >>> org-link-make-description-function? >> >> I'm not sure what sort of documentation you have in mind? What should >> I add? > > I have no idea what Ihor means. From my point of view, mention of > :insert-description and `org-link-parameters' may give a hint to users. Let me clarify. The new :insert-description parameter is a more fine-grained equivalent to already existing org-link-make-description-function. The latter can, de facto, return string or nil - it is passed to `read-string' as INITIAL-INPUT argument. So, I suggested interpreting nil return value in :insert-description just as it is already interpreted in org-link-make-description-function. Further, I asked to document that nil value is allowed - both in :insert-description docstring section and in org-link-make-description-function docstring. Best, Ihor