emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: yuvallangerontheroad <yuvallangerontheroad@proton.me>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Explain how to end a buffer narrowing.
Date: Sat, 26 Nov 2022 02:26:41 +0000	[thread overview]
Message-ID: <87tu2mlace.fsf@localhost> (raw)
In-Reply-To: <N_JRNRyiLWIW3X-Q16EizL76gf7I0Hh51Eqz5D8S-2GGXzEo1zA0F2pAZEX2byBgqbzt3RMNL50WSdM9RfLc4bNVu-i17O2_wxW2s5S_5Eo=@proton.me>

yuvallangerontheroad <yuvallangerontheroad@proton.me> writes:

>> Extra [...] are redundant.
>> Please test the patch before submitting.
>
> Sorry. Removed redundant brackets.

Thanks.

It is also a good idea to add quotes around the command key. See the
example in 25.3 Substituting Key Bindings in Documentation
(I am honestly not sure how important quoting is, but let's better
follow the Elisp manual).

Also, please make the commit message more concrete.

Maybe something like

org: Mention how to widen in docstrings of the commands that do narrowing 

Finally, please follow the commit message format as described in
https://orgmode.org/worg/org-contribute.html#commit-messages
In particular, add the changelog entries and TINYCHANGE cookie (I assume
that you don't have FSF copyright assignment).

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2022-11-26  2:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24 17:55 [PATCH] Explain how to end a buffer narrowing yuvallangerontheroad
2022-11-25 14:32 ` Ihor Radchenko
2022-11-25 14:44   ` yuvallangerontheroad
2022-11-25 14:52     ` Ihor Radchenko
2022-11-25 15:02       ` yuvallangerontheroad
2022-11-26  2:26         ` Ihor Radchenko [this message]
2022-11-29 18:20           ` yuvallangerontheroad
2022-12-05 11:25             ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu2mlace.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=yuvallangerontheroad@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).