From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id aNJdK4KPpmS8QQEASxT56A (envelope-from ) for ; Thu, 06 Jul 2023 11:55:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AGklK4KPpmR5cwAA9RJhRA (envelope-from ) for ; Thu, 06 Jul 2023 11:55:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4314E3DDC0 for ; Thu, 6 Jul 2023 11:55:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=maTRWiqm; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1688637314; a=rsa-sha256; cv=none; b=BBi5+FEqROih3QesYnseX1RkjwybNWr5gATR/mUW/31ZPY0JnUutzb9AdfEWi+Yr1A9bQm 6BED36ZH4BUkZClvp+B5D2M2wbGAfYYXQ5nO2CMMctn1DOXgTQLBUSB3fwiku1nYuZbAut Wwgg/5jQa0qsfp5nXQFsvcroNWKKeXUrxHzF5wBbmSqsbFXD/2e56gl3CU0/X/AkWeRRq4 e/kDTlN0FWI/cMGuU224ZYwQjKRYrE5OEDylngE/nxJfgovrD1/wnE9Fd25K33u47OcBgx gYV+/GUCw+s5UNmg4ywQ/tjCEbXagavyyOGEATQUd4YVkTHRcNBLVQYanVkt8g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=maTRWiqm; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1688637314; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=woy9yJEuoeCsj5ct6yJqr1h8qxqk7blUMeSuRQtYnOo=; b=W8P4GTEwMNnkSI0SbgU7xYMIzmdpFw5thh/aFRWOF0wf7M725ud5zaQ6ITFSio1/vSxUBA 2MWK6rNAUanNrf5LScDBbQGdwyeiesMNQZ6LYsWhgQmFsjls1n3UZyMDLeMYKVzn3JSrEV YliTs5YHRIB+OkCLELi+KcpDpDtpa/o+tMeRBUx+rc+eU55HkhBFocbdyU/3ASU2812Evu 8J9fwiue0s/waeTAR4x/tEgLtdmNceaOy5rhiLLFmk4AuwwhwOgJTcje+2iv7MogrKFiRj YpYe5iapnjpxcRlrkvDY9/k1YGDGxouDyYhqWr94Tn4AO7Bm+SYCBnQc1iBqSg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHLhF-0003Ge-67; Thu, 06 Jul 2023 05:54:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHLhC-0003FI-HC for emacs-orgmode@gnu.org; Thu, 06 Jul 2023 05:54:42 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHLhA-0004nA-Dm for emacs-orgmode@gnu.org; Thu, 06 Jul 2023 05:54:42 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 63ECC240105 for ; Thu, 6 Jul 2023 11:54:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1688637278; bh=3MAvKlTLpSsBEtJ/GWdzI+Lhs7oPu/Ia1nHKzGkCIVs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=maTRWiqmdeeVSxx0TM+g5Aun+ir+Pd6D+acgSHDFv5feaj2FnRaOMtB37TtsJmzUn bnw6qAnSLYzYs6t8sgrRA0vLQIGl++URp6cbYGy/sNjFeIgtXD8vc2DphEhLUvZ4Jo 7DKVxDDFXciXS9/836SO7RrevvejzhyXGutMdR5cdddm5sDDwmy5WWXRxrkn/tInBc Vz+naPhrltDy9Cht416U0meZG9n33KlQEx1H3aCUaU390SP+Sqd6rclT+ZxYRTWGu2 lYZ5IpREDWiiIzH1NAR4u89VsgKR3/Xg9rlIapnOX90wC4H5VBimUp2cNJV8aVh7aA o1vsQcl37bonA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QxX1n3gl7z6txZ; Thu, 6 Jul 2023 11:54:37 +0200 (CEST) From: Ihor Radchenko To: Max Nikulin Cc: Justin , emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix Emacs-26 compatibility (was: Re: [BUG] org-element loading fails with "regexp" argument not "stringp") In-Reply-To: <73ee6087-4c89-9d9a-cbc6-197396a023c1@gmail.com> References: <2ff109c7-b3ec-27ac-e75d-ae5ddac14746@vallon.homeip.net> <877creabn6.fsf@localhost> <73ee6087-4c89-9d9a-cbc6-197396a023c1@gmail.com> Date: Thu, 06 Jul 2023 09:54:38 +0000 Message-ID: <87ttuh74bl.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.74 X-Migadu-Queue-Id: 4314E3DDC0 X-Spam-Score: -4.74 X-TUID: Xk1tZcT47BfI Max Nikulin writes: > On 05/07/2023 17:35, Ihor Radchenko wrote: >> However, you will see many more failures with Emacs 26 on the latest >> main. > > With the couple of attached patches the only failing test is > > ... > Test test-org/delete-indentation condition: > (wrong-number-of-arguments > (0 . 1) > 3) > FAILED 935/1069 test-org/delete-indentation Yup, it is because `org-delete-indentation' now uses 3 arguments when calling `delete-indentation', while in Emacs 26 `delete-indentation' only accepted up to 1. And there are many warnings of which I have clue about the origin. Except `string-search' undefined, which is not yet available in Emacs 26. > From 2f2d330e90b10a86aa6b3b9ff279bc012b339396 Mon Sep 17 00:00:00 2001 > From: Max Nikulin > Date: Wed, 5 Jul 2023 22:50:44 +0700 > Subject: [PATCH 2/2] org-compat.el: Define `flatten-tree' for Emacs-26 > compatibility > > * lisp/org-compat.el (flatten-tree): New compatibility function > earlier used as `org-protocol-flatten'. > * lisp/org-protocol.el (org-protocol-flatten): Remove the definition > of the function. > (org-protocol-flatten-greedy): Use `flatten-tree' instead of > `org-protocol-flatten'. You are removing `org-protocol-flatten' function, which is a breaking change. We should leave an obsolete alias. Also, you are defining `flatten-tree' function, which is outside Org's namespace. We should better avoid it and use something like `org-flatten-tree'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at