From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wDcEMa3jx2TSagAASxT56A (envelope-from ) for ; Mon, 31 Jul 2023 18:39:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cIUbMK3jx2TohQAAG6o9tA (envelope-from ) for ; Mon, 31 Jul 2023 18:39:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0E5016316D for ; Mon, 31 Jul 2023 18:39:08 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=OHDlrAU+; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690821549; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AOlS5VaF5pJ8BYYGllcl86C+QDBSv6jrbi88YcwRQNg=; b=TL+n5UvJXKDESh1tow3gUDHd08uDMNOok8NY0OC4FJbLt1q5Wxtph1Kg80IklDAtdKgX0/ 6L5aRRgI28pfKOqHhUQbOwW7lo4/Ty2m+eJtcXssgovSCQ17eUC/YC0/vESPtdMi55G0Q3 Ajf+UUgCa/ucNE/0zUR2+PZZKAFO4wan00Y6YGI5UhSjKX6an7E/+8r0HIsLG7iPiCG2PS 7n+iJ7qKD/IkJxIQFBa6XOsWJkzf5Sr0WivlAFKvFLeeTSdNx+hy4TiUVdJrug/ic6sEbH uK/fUj5C5vuAdrKqslpSNC397Qd4shjq2Ex8TeiDUAr4fByORvBXA3Opm2IzCg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=OHDlrAU+; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690821549; a=rsa-sha256; cv=none; b=PviEpqJufIXam+JDs7jr6Jcr/KNcyeztrZEJp1/C77CeZppSCaoySmrlbkDY2hesr0CbBf kW2+9+zsdJeyBvZq9CGKYNCXSmunWWEKQo1lJtnauoutHyTy9qsjCmKZEwBGg9xyS89aAd rXu7H6Wb48X8wHJZHrzTaJEby9uaVNTQBsA/ervpXMxqIPWvNCEP9FAxLwaPbzypZBrjWR 8IiSKxNOa8pHwLCI2LMUQYER5yAs4QCUGoFTqNEjzaRWFfsYetdzpNQpG1e509lRMe5HQt zn1jbTsZEx3nJBcRdk2P+ZrKeQ+qAHsA/mw0PTLiIGyZzYHR0LX5kQH8oyWOvw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQVuS-0003iw-BK; Mon, 31 Jul 2023 12:38:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQVuE-0003i4-JH for emacs-orgmode@gnu.org; Mon, 31 Jul 2023 12:38:02 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQVuC-0002Oq-Hk for emacs-orgmode@gnu.org; Mon, 31 Jul 2023 12:38:02 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7A791240027 for ; Mon, 31 Jul 2023 18:37:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690821478; bh=vx98cJK47CAoOSRVi7twtjVksUR7nnWY1VuhdzfoeBo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=OHDlrAU+nXylNyjzriPj6pp1DbYb7qiRmxlLwOUaQzwnAVbMOHsesYTFqPdyzVolM s2xZqck14ceTIhBN5UyIeY7GaKONYDfmhveoPtu+zOREo+FA6Xpocb2P3a8P7tWB2i fcHJVYJJUHoVY2duAnw+Fawknj4E8Qr2xyD0X5RruuKwY/TmDV6l4L6kwGQVfTJVWq xH91KBh8Rj2An1RFpzjiILoooLXgKKfTeb7odr/GS8l26vlWRXGEKd8rpWRzP609nu 3vi08fnOb6qh5eNsqioLoVlCjeYumh7B/mKcxE0cY2iOUunroU2OecPxjE3swQaddE xMR7ZzUOpClHg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RF3nd3bq6z6v5r; Mon, 31 Jul 2023 18:37:57 +0200 (CEST) From: Ihor Radchenko To: Mehmet Tekman Cc: emacs-orgmode@gnu.org Subject: Re: [ANN] lisp/ob-tangle-sync.el In-Reply-To: References: <8735451u20.fsf@gmail.com> <874jokbjsk.fsf@localhost> <87zg6ch2dm.fsf@gmail.com> <87sfc4a0ce.fsf@localhost> <87r0ro9mzc.fsf@gmail.com> <87zg69zq49.fsf@localhost> <87r0rg1lwe.fsf@gmail.com> <87leho3y0n.fsf@localhost> <87a5y3vzpe.fsf@gmail.com> <87jzx6ylrm.fsf@localhost> <87ttw8kd9u.fsf@gmail.com> <87fs5ppcx7.fsf@localhost> <875y6hwqqe.fsf@localhost> <87o7k48jcf.fsf@localhost> <87v8e8m0ao.fsf@localhost> Date: Mon, 31 Jul 2023 16:38:09 +0000 Message-ID: <87tttkghou.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -6.31 X-Migadu-Queue-Id: 0E5016316D X-Migadu-Spam-Score: -6.31 X-Migadu-Scanner: mx0.migadu.com X-TUID: xrjRRpO6WKXC Mehmet Tekman writes: > I've adapted this to write a git patch which currently passes with > upstream/main, and contains a few `should-not` statements which are > planned to be `should` statements after the merge function has been > patched for the `:tangle' multi-parameter property. I do not like the idea of putting unrelated tests to upsteam. They may confuse people reading the sources before your follow-up patch is merged. Is there any specific reason why you want to merge these tests now and not later, when you submit the full patch? > +(ert-deftest test-ob/merge-params () > + "Test the output of merging multiple header parameters. The > +expected output is given in the contents of the source code block > +in each test. The desired test header parameters are given > +either as a symbol or a list in the `idtest-alist' variable. > +Multiple header parameters must be separated by a newline and > +exactly two spaces in the block contents." Note that you did not update the docstring after changes in the tests structure. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at