From: Ihor Radchenko <yantar92@posteo.net>
To: "Rudolf Adamkovič" <salutis@me.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix a possibly problematic string comparison
Date: Tue, 29 Aug 2023 05:10:08 +0000 [thread overview]
Message-ID: <87ttsi1ljj.fsf@localhost> (raw)
In-Reply-To: <m2a5ua90mn.fsf@me.com>
Rudolf Adamkovič <salutis@me.com> writes:
> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> This is not as trivial. Applying this patch will break tests.
>> One needs to carefully examine the org-table logic to fix this
>> particular warning.
>
> Wow! You are right. How is that even possible? In other words, what
> value (of 'elements') can possibly be object-equal to a literal "" but
> not string-equal to the same literal "" or vice versa?
This is not what is happening.
- (if (and (eq elements "") (not keep-empty))
(eq elements "") is always nil - the warning is right. We never enter
this branch of `if'.
+ (if (and (string-empty-p elements) (not keep-empty))
After the patch, we do enter this branch of `if', but it breaks tests.
So, it is not just an innocent warning - it reveals a fault in logic
elsewhere in the code.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-08-29 5:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-27 21:43 [PATCH] Fix a possibly problematic string comparison Rudolf Adamkovič
2023-08-28 8:45 ` Ihor Radchenko
2023-08-29 0:02 ` Rudolf Adamkovič
2023-08-29 5:10 ` Ihor Radchenko [this message]
2023-08-29 23:56 ` Rudolf Adamkovič
2024-05-09 9:00 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttsi1ljj.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=salutis@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).