org-element-ast.el::628:25: Warning: ‘not’ called with 3 args, but requires 1

org-element-ast.el::628:25: Warning: ‘not’ called with 3 args, but requires 1

[Max Nikulin]

Hi,

There is a warning during org compiling:

> In org-element--properties-mapc:
> org-element-ast.el:628:25: Warning: ‘not’ called with 3 args, but requires 1
> org-element-ast.el:628:30: Warning: reference to free variable ‘eq’

Likely it is a typo

diff --git a/lisp/org-element-ast.el b/lisp/org-element-ast.el
index c4c6d1c6f..f07a5f935 100644
--- a/lisp/org-element-ast.el
+++ b/lisp/org-element-ast.el
@@ -607,7 +607,7 @@ (defun org-element--properties-mapc (fun node 
&optional collect no-standard)
                       node))))
                (when collect
                  (unless (eq rtn (aref parray (cadr standard-idxs)))
-                  (if (and (eq collect 'set) (not eq rtn 
'org-element-ast--nil))
+                  (if (and (eq collect 'set) (not (eq rtn 
'org-element-ast--nil)))
                        (setf (aref parray (cadr standard-idxs)) rtn)
                      (push rtn acc))))
                (setq standard-idxs (cddr standard-idxs))))))

Re: org-element-ast.el::628:25: Warning: ‘not’ called with 3 args, but requires 1

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

> There is a warning during org compiling:
>
>> In org-element--properties-mapc:
>> org-element-ast.el:628:25: Warning: ‘not’ called with 3 args, but requires 1
>> org-element-ast.el:628:30: Warning: reference to free variable ‘eq’
>
> Likely it is a typo
>
> diff --git a/lisp/org-element-ast.el b/lisp/org-element-ast.el
> index c4c6d1c6f..f07a5f935 100644
> --- a/lisp/org-element-ast.el
> +++ b/lisp/org-element-ast.el
> @@ -607,7 +607,7 @@ (defun org-element--properties-mapc (fun node 
> &optional collect no-standard)
>                        node))))
>                 (when collect
>                   (unless (eq rtn (aref parray (cadr standard-idxs)))
> -                  (if (and (eq collect 'set) (not eq rtn 
> 'org-element-ast--nil))
> +                  (if (and (eq collect 'set) (not (eq rtn 
> 'org-element-ast--nil)))

Thanks!
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=55db64e9d

The irony is that I saw the warning, looked into the code, and somehow
thought that it is a false-positive (the warning is not displayed in all
the Emacs versions).

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>