From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-element-ast.el::628:25: Warning: ‘not’ called with 3 args, but requires 1
Date: Wed, 25 Oct 2023 13:50:57 +0000 [thread overview]
Message-ID: <87ttqedd4u.fsf@localhost> (raw)
In-Reply-To: <uhb60m$10d5$1@ciao.gmane.io>
Max Nikulin <manikulin@gmail.com> writes:
> There is a warning during org compiling:
>
>> In org-element--properties-mapc:
>> org-element-ast.el:628:25: Warning: ‘not’ called with 3 args, but requires 1
>> org-element-ast.el:628:30: Warning: reference to free variable ‘eq’
>
> Likely it is a typo
>
> diff --git a/lisp/org-element-ast.el b/lisp/org-element-ast.el
> index c4c6d1c6f..f07a5f935 100644
> --- a/lisp/org-element-ast.el
> +++ b/lisp/org-element-ast.el
> @@ -607,7 +607,7 @@ (defun org-element--properties-mapc (fun node
> &optional collect no-standard)
> node))))
> (when collect
> (unless (eq rtn (aref parray (cadr standard-idxs)))
> - (if (and (eq collect 'set) (not eq rtn
> 'org-element-ast--nil))
> + (if (and (eq collect 'set) (not (eq rtn
> 'org-element-ast--nil)))
Thanks!
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=55db64e9d
The irony is that I saw the warning, looked into the code, and somehow
thought that it is a false-positive (the warning is not displayed in all
the Emacs versions).
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2023-10-25 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 13:42 org-element-ast.el::628:25: Warning: ‘not’ called with 3 args, but requires 1 Max Nikulin
2023-10-25 13:50 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttqedd4u.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).