From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id mJFTD7TRL2Z+ogAAe85BDQ:P1 (envelope-from ) for ; Mon, 29 Apr 2024 18:58:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id mJFTD7TRL2Z+ogAAe85BDQ (envelope-from ) for ; Mon, 29 Apr 2024 18:58:28 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=fejkJgmJ; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714409908; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tQWS/Naox0+EWKs96kOJ6oHikAtQz1UNAzPDbevL2Ro=; b=r/E4OGi9xoNuNh8rATatRtnFNXie7p3pzvx30bvWgdLY2xWVBEVYJwbFubq3hxYHznjOg1 e+a6Y7n4aCW64R/uBdgvoBFi/WfScF/DyGnrcP4epOENlACraWlwxUqeylF94lSN9Ffm8Z y8G9lSI6EEXbhZuWtfaKIXdyWuetGyobdV9sbKxzaF0/yZyzCwZ7/XaKSLjgIuzeFQ0HLw C00n4KV8uWimDgT6cBbQZaQA5ONhQ0LjyH9mH+hnz8vBjFt4nMMecF5DTClEKSrZAKKnXb 1tyDYQ51RVIWpa7YhbrmTX00Q0BAuWpst01dgxkZDLNXxgm5XKoeGBQDSITqrg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=fejkJgmJ; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714409908; a=rsa-sha256; cv=none; b=QRiIoeuKUi6Ln+Hqw5WIm2fB5xOTKkw4cHWy/go8LSNJH4L2PFLU6928vD6xDVeaFVi2RR PUZCUyOR+QhRcY8WbD7gzsHPtD/qawsA1jOT0PiuP0WItkGYpSFyWsSQRo2pgwV0Wp7vJO m+XvE6F0wxUFxjPM2N3NHvtrNCqLAMgTTwojkCMn94f5DJ9L7r0bGeLEHzVG3+undA/Pn9 2b9C8g3Dns1NmU998B8VICj/4GdKEjBIKD58XG+yLBA5s65rdUJWRHW28m97/CfNKbLLCX P2lqo28KjYQf1IXEzqGIA4XC5LZngJuBFB+RBNR679VIcxlHb7pm9pzmGrscfA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1C9CA55901 for ; Mon, 29 Apr 2024 18:58:28 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1UKA-0006eg-Pn; Mon, 29 Apr 2024 12:57:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1UK9-0006eU-3m for emacs-orgmode@gnu.org; Mon, 29 Apr 2024 12:57:53 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1UK6-0003vC-0K for emacs-orgmode@gnu.org; Mon, 29 Apr 2024 12:57:52 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9171C240101 for ; Mon, 29 Apr 2024 18:57:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714409867; bh=n97gJxRpzs/CIJpZbsiIazr9jCx7a4WydRspn3Sqagg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=fejkJgmJRMmNqYsCl54X291gi1aeDBYMccHWXpKT2t7ZGO39RsSY9Eakf4H2bTF/L xkvvQmUgRt/RT11IzSHndUtF7iw50IXw8svryVuB1XhVNEl5vV6GxdEkI+XbpGe1sC q8pl6N2GYqsZrrX3H4S5dH4fDk0qFU+nJNZZihr5+UTF3Lc6ZAG516VJCWwoMFCuWY B2tyVC2YkjASdVptlPxPbbJMye4xC/hnd5a1s5U7fZ23K5lD404rih1o1Scj0+g3n4 JbU9q/rl20MZCcwZgUzR+QlS9I7ecWkIYEwy3O2Wu882SrJwQWj+sBYvilVjZgNCUo mD+2Ipg56fntw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VSqJW0PHTz6twC; Mon, 29 Apr 2024 18:57:46 +0200 (CEST) From: Ihor Radchenko To: Morgan Smith Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org.el: Obsolete `org-cached-entry-get' in favor of `org-entry-get' In-Reply-To: References: Date: Mon, 29 Apr 2024 16:58:48 +0000 Message-ID: <87ttjkaywn.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.45 X-Spam-Score: -7.45 X-Migadu-Queue-Id: 1C9CA55901 X-Migadu-Scanner: mx13.migadu.com X-TUID: WY5XIAjvnoUE Morgan Smith writes: > * lisp/org.el (org-cached-entry-get): Rewrite in terms > `org-entry-get'. Obsolete in favor of `org-entry-get'. > (org-make-tags-matcher): Replace uses of `org-cached-entry-get' with > `org-entry-get'. > --- > Hello! > > All tests pass. > > All of the logic here already exists in `org-entry-get'. > > This function is mentioned in very few commits unlike its more popular sibling. This function should yield speedups when matching special properties like "CLOCKSUM", "CLOCKSUM_T", "TIMESTAMP", or "TIMESTAMP_IA". For example, when the requested match tests these properties multiple times. > I don't think we can justify the existence of this function but let me know if > I'm wrong. > > The caching mechanism used here is likely to cause hard to diagnose issues. If you encountered such issue, please let me know. Otherwise, I do not see any reason to remove `org-cached-entry-get'. We need a real-life justification, not a theoretical one. Canceled. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at