Re: ob-shell: possibly missing initiate-session functions?

[Suhail Singh <suhailsingh247@gmail.com>]

Ihor Radchenko <yantar92@posteo.net> writes:

> Fixed, on main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5b366a731

#+begin_src diff
         (put fname 'definition-name 'org-babel-shell-initialize))
  +    (let ((fname (intern (concat "org-babel-prep-session:" name))))
  +      (defalias fname
  +        (lambda (session params)
  +	  (:documentation
  +           (format "Prepare %s SESSION according to the header arguments specified in PARAMS." name))
  +	  (let ((explicit-shell-file-name name)
  +                (shell-file-name name))
  +	    (org-babel-prep-session:shell session params))))
  +      (put fname 'definition-name 'org-babel-shell-initialize))
  +    (let ((fname (intern (format "org-babel-%s-initiate-session" name))))
  +      (defalias fname
  +        (lambda (session _params)
  +	  (:documentation
  +           (format "Initiate %s session named SESSION." name))
  +	  (let ((explicit-shell-file-name name)
  +                (shell-file-name name))
  +	    (org-babel-sh-initiate-session session))))
  +      (put fname 'definition-name 'org-babel-shell-initialize))
#+end_src

Am I mistaken, or does something still need to be done about
org-babel-shell-initiate-session ?

-- 
Suhail