[PATCH] lisp/lisp/ob-core.el (org-babel-merge-params): Rename plists to alists

[PATCH] lisp/lisp/ob-core.el (org-babel-merge-params): Rename plists to alists

[Matthias Hetzenberger]

[-- Attachment #1.1: Type: text/plain, Size: 222 bytes --]

Hello!

I noticed that in the function org-babel-merge-params the arguments are
alists rather than plists.
To this end, I created a patch that updates the relevant variable names as
well as the docstring (see attachment).

[-- Attachment #1.2: Type: text/html, Size: 436 bytes --]

[-- Attachment #2: 0001-org-babel-merge-params-Rename-plists-to-alists.patch --]
[-- Type: text/x-patch, Size: 1395 bytes --]

From db9d5b77aedfb87aa0a3382f6be9d5921eef2ffd Mon Sep 17 00:00:00 2001
From: Matthias Hetzenberger <mhetzenberger@gmail.com>
Date: Sat, 22 Jun 2024 16:06:41 +0200
Subject: [PATCH] org-babel-merge-params: Rename plists to alists

---
 lisp/ob-core.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lisp/ob-core.el b/lisp/ob-core.el
index db75f1f0a..5b32f503b 100644
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -2959,9 +2959,9 @@ used as a string to be appended to #+begin_example line."
       (goto-char body-start)
       (insert body))))
 
-(defun org-babel-merge-params (&rest plists)
-  "Combine all parameter association lists in PLISTS.
-Later elements of PLISTS override the values of previous elements.
+(defun org-babel-merge-params (&rest alists)
+  "Combine all parameter association lists in ALISTS.
+Later elements of ALISTS override the values of previous elements.
 This takes into account some special considerations for certain
 parameters when merging lists."
   (let* ((results-exclusive-groups
@@ -2990,8 +2990,8 @@ parameters when merging lists."
 	 ;; Some keywords accept multiple values.  We need to treat
 	 ;; them specially.
 	 vars results exports)
-    (dolist (plist plists)
-      (dolist (pair plist)
+    (dolist (alist alists)
+      (dolist (pair alist)
 	(pcase pair
 	  (`(:var . ,value)
 	   (let ((name (cond
-- 
2.45.1

Re: [PATCH] lisp/lisp/ob-core.el (org-babel-merge-params): Rename plists to alists

[Ihor Radchenko]

Matthias Hetzenberger <mhetzenberger@gmail.com> writes:

> I noticed that in the function org-babel-merge-params the arguments are
> alists rather than plists.
> To this end, I created a patch that updates the relevant variable names as
> well as the docstring (see attachment).

Thanks!
Applied, onto bugfix, after adding a proper commit message with
changelog entries and TINYCHANGE cookie (you do not appear to have FSF
copyright assignemnt).

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=bd16944e1

I also added you to the contributor list:
https://git.sr.ht/~bzg/worg/commit/6108ef9a

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>