emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Robert Pluim <rpluim@gmail.com>
Cc: Visuwesh <visuweshm@gmail.com>, "Sébastien Gendre" <seb@k-7.ch>,
	org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: Cannot yank media when image come from Gnome screenshot
Date: Mon, 05 Aug 2024 17:44:43 +0000	[thread overview]
Message-ID: <87ttfykgok.fsf@localhost> (raw)
In-Reply-To: <871q33vvdb.fsf@gmail.com>

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Sun, 04 Aug 2024 19:01:24 +0000, Ihor Radchenko <yantar92@posteo.net> said:
>
>     Ihor> I am not sure if I like patching Emacs functions when loading Org mode.
>     Ihor> On the other hand, I do not see any obvious downside.
>
> I was hoping youʼd have a strong opinion 😀

Generally speaking, defining global methods is a very bad practice.
But I feel that it _might_ be justified in this particular case.

>     Ihor> Robert, what do you think about such idea? 
>
> Itʼs a cl-defmethod that I assume you will hide behind a version
> check, and the changed code itself should only run for a pgtk emacs,
> so I donʼt see a great risk. And in the absolute worst case
> `yank-media' doesnʼt work, which is the situation we already have.

Yes, behind version check, pgtk build check, and, ideally, after
checking that such method is not yet defined.
May you create such a patch against Org mode repository?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-08-05 17:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-23  8:10 Cannot yank media when image come from Gnome screenshot Sébastien Gendre
2024-07-23  9:52 ` Ihor Radchenko
2024-07-23 10:24   ` Sébastien Gendre
2024-07-23 10:29     ` Ihor Radchenko
2024-07-23 10:47       ` Sébastien Gendre
2024-07-23 10:50         ` Ihor Radchenko
2024-07-26 18:35       ` Ihor Radchenko
2024-08-01  6:07         ` Visuwesh
2024-08-04 19:01           ` Ihor Radchenko
2024-08-05 15:32             ` Robert Pluim
2024-08-05 17:44               ` Ihor Radchenko [this message]
2024-08-05 19:03                 ` Robert Pluim
2024-08-05 19:07                   ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttfykgok.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=rpluim@gmail.com \
    --cc=seb@k-7.ch \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).