emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Benjamin McMillan <mcmillanbb@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] export blocks no longer fontifying [9.7.10 (release_9.7.10 @ /Users/ben/Scripts/emacs/lisp/org/)]
Date: Sun, 22 Sep 2024 09:53:07 +0000	[thread overview]
Message-ID: <87tte8qakc.fsf@localhost> (raw)
In-Reply-To: <CALo8A5Vm-gik0qQC7KacNg7kN2VzL0Y1e8_LXxV8S7-we9CYSw@mail.gmail.com>

[ Adding Org mailing list back to CC to keep the conversation public ]

Benjamin McMillan <mcmillanbb@gmail.com> writes:

> Dear Ihor,
> I am happy to make the changes.
> I am not sure what exactly made the last commit message read like a new
> feature, but hopefully the following is better:
> lisp/org.el: Add "export" to list of native fontified blocks
> If not, I can modify again.

Thanks!
Applied, onto bugfix.
I modified the commit message a bit.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=2a85367ea8

I also added you to the contributor list.
https://git.sr.ht/~bzg/worg/commit/84bb23ce

Fixed.

> And thanks for the explanation, it makes sense.
>
> Regards the logs, it may be because I don't have the org git repository set
> up properly.
> I cloned the source into a folder that has no relation to my emacs setup,
> so that might be causing problems.
> Logs:
> Ran 1284 tests, 1216 results as expected, 55 unexpected, 13 skipped
> (2024-09-17 19:52:08+0900, 75.466775 sec)
> 2 expected failures
> ...

Most of the failing tests are concerning running external programs (java
and maxima). It looks like you have them installed, but they somehow
misbehave. Maybe old versions?

>    FAILED  test-org-table/sort-lines  ((should (equal "| a | x |\n| B | 4
> |\n| c | 3 |\n" (org-test-with-temp-text "| <point>a | x |\n| c | 3 |\n| B
> | 4 |\n" (org-table-sort-lines nil 97) (buffer-string)))) :form (equal "| a
> | x |\n| B | 4 |\n| c | 3 |\n" #("| B | 4 |\n| a | x |\n| c | 3 |\n" 0 9
> (face org-table) 9 10 (face org-table-row) 10 19 (face org-table) 19 20
> (face org-table-row) 20 29 (face org-table) 29 30 (face org-table-row)))
> :value nil :explanation (array-elt 2 (different-atoms (97 "#x61" "?a") (66
> "#x42" "?B"))))

This is probably your locale. The test is checking sorting and sorting
depends on language settings. This one is kind of expected. Although it
would be nice to make test account for locales as well.

> 55 unexpected results:
>    FAILED  ob-java/args-quoted-string  ((should (string= "forty two\n42\n"
> (org-babel-execute-src-block))) :form (string= "forty two\n42\n" "") :value
> nil :explanation (arrays-of-different-length 13 0 "forty two\n42\n" ""
> first-mismatch-at 0))
>    FAILED  ob-java/import_library  ((should (string= "encoded=NDI=,
> decoded=42" (org-babel-execute-src-block))) :form (string= "encoded=NDI=,
> decoded=42" "") :value nil :explanation (arrays-of-different-length 24 0
> "encoded=NDI=, decoded=42" "" first-mismatch-at 0))
>    FAILED  ob-java/import_library_inline  ((should (string= "encoded=NDI=,
> decoded=42" (org-babel-execute-src-block))) :form (string= "encoded=NDI=,
> decoded=42" "") :value nil :explanation (arrays-of-different-length 24 0
> "encoded=NDI=, decoded=42" "" first-mismatch-at 0))
>    FAILED  ob-java/inhomogeneous_table  ((should (equal '(("forty" 4)
> ("two" 2)) (org-babel-execute-src-block))) :form (equal (("forty" 4) ("two"
> 2)) "") :value nil :explanation (different-types (("forty" 4) ("two" 2))
> ""))
>    FAILED  ob-java/integer-var  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/list-var  ((should (equal '("forty" "two")
> (org-babel-execute-src-block))) :form (equal ("forty" "two") "") :value nil
> :explanation (different-types ("forty" "two") ""))
>    FAILED  ob-java/matrix-var  ((should (equal '((2 4) (1 2))
> (org-babel-execute-src-block))) :form (equal ((2 4) (1 2)) "") :value nil
> :explanation (different-types ((2 4) (1 2)) ""))
>    FAILED  ob-java/matrix-var-with-header  ((should (equal '(("col1"
> "col2") hline (2 4) (1 2)) (org-babel-execute-src-block))) :form (equal
> (("col1" "col2") hline (2 4) (1 2)) ((""))) :value nil :explanation
> (proper-lists-of-different-length 4 1 (("col1" "col2") hline (2 4) (1 2))
> (("")) first-mismatch-at 0))
>    FAILED  ob-java/one-arg  ((should (string= "fortytwo"
> (org-babel-execute-src-block))) :form (string= "fortytwo" "") :value nil
> :explanation (arrays-of-different-length 8 0 "fortytwo" ""
> first-mismatch-at 0))
>    FAILED  ob-java/output-list-with-spaces  ((should (equal "forty
> two\nforty two\n" (org-babel-execute-src-block))) :form (equal "forty
> two\nforty two\n" "") :value nil :explanation (arrays-of-different-length
> 20 0 "forty two\nforty two\n" "" first-mismatch-at 0))
>    FAILED  ob-java/output-table-with-header  ((should (equal
> "|col1|col2|\n|-\n|2|1\n|4|2\n" (org-babel-execute-src-block))) :form
> (equal "|col1|col2|\n|-\n|2|1\n|4|2\n" "") :value nil :explanation
> (arrays-of-different-length 25 0 "|col1|col2|\n|-\n|2|1\n|4|2\n" ""
> first-mismatch-at 0))
>    FAILED  ob-java/read-list-return-array  ((should (equal '("forty" "two")
> (org-babel-execute-src-block))) :form (equal ("forty" "two") "") :value nil
> :explanation (different-types ("forty" "two") ""))
>    FAILED  ob-java/read-return-list  ((should (equal '("forty" "two")
> (org-babel-execute-src-block))) :form (equal ("forty" "two") "") :value nil
> :explanation (different-types ("forty" "two") ""))
>    FAILED  ob-java/read-return-list-with-package  ((should (equal '("forty"
> "two") (org-babel-execute-src-block))) :form (equal ("forty" "two") "")
> :value nil :explanation (different-types ("forty" "two") ""))
>    FAILED  ob-java/return-vector-using-array  ((should (equal '((4) (2))
> (org-babel-execute-src-block))) :form (equal ((4) (2)) ((""))) :value nil
> :explanation (proper-lists-of-different-length 2 1 ((4) (2)) ((""))
> first-mismatch-at 0))
>    FAILED  ob-java/return-vector-using-list  ((should (equal '((4) (2))
> (org-babel-execute-src-block))) :form (equal ((4) (2)) ((""))) :value nil
> :explanation (proper-lists-of-different-length 2 1 ((4) (2)) ((""))
> first-mismatch-at 0))
>    FAILED  ob-java/simple  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/simple-dir  ((should (string= "42" (unwind-protect
> (org-babel-execute-src-block) (delete-file (concat ... "Main.java"))
> (delete-file (concat ... "Main.class"))))) :form (string= "42" "") :value
> nil :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at
> 0))
>    FAILED  ob-java/simple-dir-with-package  ((should (string= "42"
> (unwind-protect (org-babel-execute-src-block) (delete-file (concat ...
> "pkg/Main.java")) (delete-file (concat ... "pkg/Main.class"))
> (delete-directory (concat ... "pkg"))))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/simple-return-float  ((should (equal 42.0
> (org-babel-execute-src-block))) :form (equal 42.0 "") :value nil
> :explanation (different-types 42.0 ""))
>    FAILED  ob-java/simple-return-int  ((should (eq 42
> (org-babel-execute-src-block))) :form (eq 42 "") :value nil)
>    FAILED  ob-java/simple-return-string  ((should (string= "forty two"
> (org-babel-execute-src-block))) :form (string= "forty two" "") :value nil
> :explanation (arrays-of-different-length 9 0 "forty two" ""
> first-mismatch-at 0))
>    FAILED  ob-java/simple-with-bracket  ((should (string= "[42"
> (org-babel-execute-src-block))) :form (string= "[42" "") :value nil
> :explanation (arrays-of-different-length 3 0 "[42" "" first-mismatch-at 0))
>    FAILED  ob-java/simple-with-class  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/simple-with-class-and-package  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/simple-with-class-attr  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/simple-with-class-attr-with-package  ((should (string=
> "42" (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/simple-with-main  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/simple-with-main-args-array  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/simple-with-main-whitespace  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/simple-with-no-main  ((should (string= "success"
> (org-babel-execute-src-block))) :form (string= "success" "") :value nil
> :explanation (arrays-of-different-length 7 0 "success" "" first-mismatch-at
> 0))
>    FAILED  ob-java/simple-with-non-public-class  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/simple-with-quote  ((should (string= "\"42\""
> (org-babel-execute-src-block))) :form (string= "\"42\"" "") :value nil
> :explanation (arrays-of-different-length 4 0 "\"42\"" "" first-mismatch-at
> 0))
>    FAILED  ob-java/simple-with-two-methods  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/string-var  ((should (string= "forty two, len=9"
> (org-babel-execute-src-block))) :form (string= "forty two, len=9" "")
> :value nil :explanation (arrays-of-different-length 16 0 "forty two, len=9"
> "" first-mismatch-at 0))
>    FAILED  ob-java/two-vars  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/var-with-class  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/var-with-class-and-hanging-curlies  ((should (string=
> "42" (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/var-with-class-and-package  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/var-with-main  ((should (string= "42"
> (org-babel-execute-src-block))) :form (string= "42" "") :value nil
> :explanation (arrays-of-different-length 2 0 "42" "" first-mismatch-at 0))
>    FAILED  ob-java/vector-var  ((should (equal '("forty" "two")
> (org-babel-execute-src-block))) :form (equal ("forty" "two") "") :value nil
> :explanation (different-types ("forty" "two") ""))
>    FAILED  ob-maxima/batch+verbatim  ((should (equal
> (org-babel-execute-src-block) "(assume(z >
> 0),integrate(exp(-t)*t^z,t,0,inf))\n
> gamma(z + 1)")) :form (equal "(linenum:0,\n(assume(z >
> 0),integrate(exp(-t)*t^z,t,0,inf))\n
> gamma(z + 1)" "(assume(z > 0),integrate(exp(-t)*t^z,t,0,inf))\n
>                     gamma(z + 1)") :value nil :explanation
> (arrays-of-different-length 104 92 "(linenum:0,\n(assume(z >
> 0),integrate(exp(-t)*t^z,t,0,inf))\n
> gamma(z + 1)" "(assume(z > 0),integrate(exp(-t)*t^z,t,0,inf))\n
>                     gamma(z + 1)" first-mismatch-at 1))
>    FAILED  ob-maxima/batch+verbatim+:lisp  ((should (equal
> (org-babel-execute-src-block) "((%GAMMA SIMP) ((MPLUS SIMP) 1 $Z))")) :form
> (equal "(%i1) (linenum:0,\n((%GAMMA SIMP) ((MPLUS SIMP) 1 $Z))" "((%GAMMA
> SIMP) ((MPLUS SIMP) 1 $Z))") :value nil :explanation
> (arrays-of-different-length 53 35 "(%i1) (linenum:0,\n((%GAMMA SIMP)
> ((MPLUS SIMP) 1 $Z))" "((%GAMMA SIMP) ((MPLUS SIMP) 1 $Z))"
> first-mismatch-at 1))
>    FAILED  ob-maxima/batch+verbatim+empty-string  ((should (equal
> (org-babel-execute-src-block) "(%i1) \"\"\n(%o1) ")) :form (equal "(%i1)
> (linenum:0,\n(%i1) \"\"\n(%o1) " "(%i1) \"\"\n(%o1) ") :value nil
> :explanation (arrays-of-different-length 33 15 "(%i1) (linenum:0,\n(%i1)
> \"\"\n(%o1) " "(%i1) \"\"\n(%o1) " first-mismatch-at 6))
>    FAILED  ob-maxima/batch+verbatim+empty-string-vq  ((should (equal
> (org-babel-execute-src-block) "\"\"\n ")) :form (equal "(linenum:0,\n\"\"\n
> " "\"\"\n ") :value nil :explanation (arrays-of-different-length 16 4
> "(linenum:0,\n\"\"\n " "\"\"\n " first-mismatch-at 0))
>    FAILED  ob-maxima/batch+verbatim+quiet  ((should (equal
> (org-babel-execute-src-block) "(%i1) (assume(z >
> 0),integrate(exp(-t)*t^z,t,0,inf))\n(%o1)
>  gamma(z + 1)")) :form (equal "(%i1) (linenum:0,\n(%i1) (assume(z >
> 0),integrate(exp(-t)*t^z,t,0,inf))\n(%o1)
>  gamma(z + 1)" "(%i1) (assume(z > 0),integrate(exp(-t)*t^z,t,0,inf))\n(%o1)
>                            gamma(z + 1)") :value nil :explanation
> (arrays-of-different-length 116 98 "(%i1) (linenum:0,\n(%i1) (assume(z >
> 0),integrate(exp(-t)*t^z,t,0,inf))\n(%o1)
>  gamma(z + 1)" "(%i1) (assume(z > 0),integrate(exp(-t)*t^z,t,0,inf))\n(%o1)
>                            gamma(z + 1)" first-mismatch-at 7))
>    FAILED  ob-maxima/batch+verbatim+whitespace-string  ((should (equal
> (org-babel-execute-src-block) "(%i1) \" \"\n(%o1)
>         ")) :form (equal "(%i1) (linenum:0,\n(%i1) \" \"\n(%o1)
>                       " "(%i1) \" \"\n(%o1)
>   ") :value nil :explanation (arrays-of-different-length 68 50 "(%i1)
> (linenum:0,\n(%i1) \" \"\n(%o1)                                   " "(%i1)
> \" \"\n(%o1)                                   " first-mismatch-at 6))
>    FAILED  ob-maxima/integer-input  ((should (equal 4
> (org-babel-execute-src-block))) :form (equal 4 (("(linenum:0,") (4)))
> :value nil :explanation (different-types 4 (("(linenum:0,") (4))))
>    FAILED  ob-maxima/list-input  ((should (equal "[2, [2, 3], 4] "
> (org-babel-execute-src-block))) :form (equal "[2, [2, 3], 4] "
> "(linenum:0,\n[2, [2, 3], 4] ") :value nil :explanation
> (arrays-of-different-length 15 27 "[2, [2, 3], 4] " "(linenum:0,\n[2, [2,
> 3], 4] " first-mismatch-at 0))
>    FAILED  ob-maxima/matrix-output  ((should (equal '((1 2 3) (2 3 4) (3 4
> 5)) (org-babel-execute-src-block))) :form (equal ((1 2 3) (2 3 4) (3 4 5))
> (("(linenum:0," "" "") (1 2 3) (2 3 4) (3 4 5))) :value nil :explanation
> (proper-lists-of-different-length 3 4 ((1 2 3) (2 3 4) (3 4 5))
> (("(linenum:0," "" "") (1 2 3) (2 3 4) (3 4 5)) first-mismatch-at 0))
>    FAILED  ob-maxima/simple-list-input  ((should (equal "[1, 2, 3] "
> (org-babel-execute-src-block))) :form (equal "[1, 2, 3] " "(linenum:0,\n[1,
> 2, 3] ") :value nil :explanation (arrays-of-different-length 10 22 "[1, 2,
> 3] " "(linenum:0,\n[1, 2, 3] " first-mismatch-at 0))
>    FAILED  ob-maxima/string-input  ((should (equal "- sin(x)"
> (org-babel-execute-src-block))) :form (equal "- sin(x)" (("(linenum:0," "")
> ("-" "sin(x)"))) :value nil :explanation (different-types "- sin(x)"
> (("(linenum:0," "") ("-" "sin(x)"))))
>    FAILED  ob-maxima/table-input1  ((should (equal "[[2.0], [3.0]] "
> (org-babel-execute-src-block))) :form (equal "[[2.0], [3.0]] "
> "(linenum:0,\n[[2.0], [3.0]] ") :value nil :explanation
> (arrays-of-different-length 15 27 "[[2.0], [3.0]] " "(linenum:0,\n[[2.0],
> [3.0]] " first-mismatch-at 0))
>    FAILED  ob-maxima/table-input2  ((should (equal "[[2.0, 3.0]] "
> (org-babel-execute-src-block))) :form (equal "[[2.0, 3.0]] "
> "(linenum:0,\n[[2.0, 3.0]] ") :value nil :explanation
> (arrays-of-different-length 13 25 "[[2.0, 3.0]] " "(linenum:0,\n[[2.0,
> 3.0]] " first-mismatch-at 0))
>    FAILED  test-org-table/sort-lines  ((should (equal "| a | x |\n| B | 4
> |\n| c | 3 |\n" (org-test-with-temp-text "| <point>a | x |\n| c | 3 |\n| B
> | 4 |\n" (org-table-sort-lines nil 97) (buffer-string)))) :form (equal "| a
> | x |\n| B | 4 |\n| c | 3 |\n" #("| B | 4 |\n| a | x |\n| c | 3 |\n" 0 9
> (face org-table) 9 10 (face org-table-row) 10 19 (face org-table) 19 20
> (face org-table-row) 20 29 (face org-table) 29 30 (face org-table-row)))
> :value nil :explanation (array-elt 2 (different-atoms (97 "#x61" "?a") (66
> "#x42" "?B"))))
>
> 13 skipped results:
>   SKIPPED  org-missing-dependency/test-ob-R  ((skip-unless nil) :form nil
> :value nil)
>   SKIPPED  org-missing-dependency/test-ob-clojure  ((skip-unless nil) :form
> nil :value nil)
>   SKIPPED  org-missing-dependency/test-ob-haskell-ghci  ((skip-unless nil)
> :form nil :value nil)
>   SKIPPED  org-missing-dependency/test-ob-julia  ((skip-unless nil) :form
> nil :value nil)
>   SKIPPED  org-missing-dependency/test-ob-lua  ((skip-unless nil) :form nil
> :value nil)
>   SKIPPED  org-missing-dependency/test-ob-octave  ((skip-unless nil) :form
> nil :value nil)
>   SKIPPED  org-missing-dependency/test-ob-python  ((skip-unless nil) :form
> nil :value nil)
>   SKIPPED  org-missing-dependency/test-ob-ruby  ((skip-unless nil) :form
> nil :value nil)
>   SKIPPED  org-missing-dependency/test-ob-scheme  ((skip-unless nil) :form
> nil :value nil)
>   SKIPPED  org-missing-dependency/test-org-attach-git  ((skip-unless nil)
> :form nil :value nil)
>   SKIPPED  test-ob-shell/bash-uses-assoc-arrays  ((skip-unless (if-let
> ((bash (executable-find "bash"))) (eq 0 (process-file bash nil nil nil "-c"
> "declare -A assoc_array")))) :form (let* ((bash (and t (executable-find
> "bash")))) (if bash (eq 0 (process-file bash nil nil nil "-c" "declare -A
> assoc_array")) nil)) :value nil)
>   SKIPPED  test-ob-shell/bash-uses-assoc-arrays-with-lists  ((skip-unless
> (if-let ((bash (executable-find "bash"))) (eq 0 (process-file bash nil nil
> nil "-c" "declare -A assoc_array")))) :form (let* ((bash (and t
> (executable-find "bash")))) (if bash (eq 0 (process-file bash nil nil nil
> "-c" "declare -A assoc_array")) nil)) :value nil)
>   SKIPPED  test-org-fold/org-fold-display-inline-images  ((skip-unless (not
> noninteractive)) :form (not t) :value nil)
>
> make: *** [test] Error 1
>
>
>
>
>
>
> On Wed, Sep 18, 2024 at 3:43 AM Ihor Radchenko <yantar92@posteo.net> wrote:
>
>> Benjamin McMillan <mcmillanbb@gmail.com> writes:
>>
>> > I attach the patch here.
>>
>> Thanks!
>>
>> > However, I have two questions.
>> > First, I am not certain that I set up the repository correctly, because
>> > when I run "make test" it generates 55 unexpected failures. This without
>> > making any changes.
>> > (The patch submitted here does not generate any new failures.)
>>
>> That's odd. May you share the log?
>>
>> > Second, the existing comment at the patch becomes slightly out of date
>> with
>> > the change.
>>
>> Then, may you please update the comment?
>>
>> Also, may you change the commit message to not sound like it is a new
>> feature? Just explain the purpose of the change as you did in this
>> email thread (but shorter, and then add a link to this thread).
>>
>> > In fact, I propose that it might be good to update the docstring for
>> > `org-src-fontify-natively' to explicitly state that it enable
>> fontification
>> > for src, example, and export blocks.
>>
>> I'd rather not document this in `org-src-fontify-natively'. The name of
>> this variable does not really hint that it has anything to do with
>> export or example blocks.
>>
>> We may eventually rename it to something more generic, but example
>> blocks may need to be re-considered because specifying language of the
>> example block is not even a part of Org syntax. So, generalizing and
>> documenting this is a bit tricky.
>>
>> --
>> Ihor Radchenko // yantar92,
>> Org mode contributor,
>> Learn more about Org mode at <https://orgmode.org/>.
>> Support Org development at <https://liberapay.com/org-mode>,
>> or support my work at <https://liberapay.com/yantar92>
>>
> From c245df2136778fd34d3ed263208331ca4e35e54d Mon Sep 17 00:00:00 2001
> From: Benjamin McMillan <mcmillanbb@gmail.com>
> Date: Fri, 20 Sep 2024 23:43:55 +0900
> Subject: [PATCH] lisp/org.el: Add "export" to list of native fontified blocks
>
> * lisp/org.el (org-fontify-meta-lines-and-blocks-1): Add "export" to
> list of block types that are fontified if org-src-fontify-natively
> is non-nil.
>
> Link: https://list.orgmode.org/87h6aejf17.fsf@localhost/
> TINYCHANGE
> ---
>  lisp/org.el | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index d5c1dcb35..df58b47be 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -5490,14 +5490,14 @@ by a #."
>  	    (org-remove-flyspell-overlays-in nl-before-endline end-of-endline)
>              (cond
>  	     ((and org-src-fontify-natively
> -                   ;; Technically, according to
> +                   ;; Technically, according to the
>                     ;; `org-src-fontify-natively' docstring, we should
>                     ;; only fontify src blocks.  However, it is common
> -                   ;; to use undocumented fontification of example
> -                   ;; blocks with undocumented language specifier.
> -                   ;; Keep this undocumented feature for user
> -                   ;; convenience.
> -                   (member block-type '("src" "example")))
> +                   ;; to use undocumented fontification of export and
> +                   ;; example blocks. (The latter which do not support a
> +                   ;; language specifier.) Keep this undocumented feature
> +                   ;; for user convenience.
> +                   (member block-type '("src" "export" "example")))
>  	      (save-match-data
>                  (org-src-font-lock-fontify-block (or lang "") block-start block-end))
>  	      (add-text-properties bol-after-beginline block-end '(src-block t)))
> -- 
> 2.46.0
>

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  parent reply	other threads:[~2024-09-22  9:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-01  4:35 [BUG] export blocks no longer fontifying [9.7.10 (release_9.7.10 @ /Users/ben/Scripts/emacs/lisp/org/)] Benjamin McMillan
2024-09-10 17:01 ` Ihor Radchenko
2024-09-16 14:27   ` Benjamin McMillan
2024-09-17 12:29     ` Benjamin McMillan
2024-09-17 18:44       ` Ihor Radchenko
     [not found]         ` <CALo8A5Vm-gik0qQC7KacNg7kN2VzL0Y1e8_LXxV8S7-we9CYSw@mail.gmail.com>
2024-09-22  9:53           ` Ihor Radchenko [this message]
2024-09-23 13:17             ` Benjamin McMillan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tte8qakc.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=mcmillanbb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).