From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric S Fraga Subject: Re: Re: Fontification of blocks Date: Thu, 03 Feb 2011 20:05:14 +0000 Message-ID: <87sjw4ubnp.fsf@ucl.ac.uk> References: <80aakevw4w.fsf@missioncriticalit.com> <8739q1ihas.fsf@gmail.com> <80r5dlpfj6.fsf@missioncriticalit.com> <87ei9jkl0l.fsf@gmail.com> <80sjw7qxem.fsf@missioncriticalit.com> <80ei7q9is6.fsf@missioncriticalit.com> <871v3pp3e3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from [140.186.70.92] (port=34445 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pl5Qo-0007U3-Kr for emacs-orgmode@gnu.org; Thu, 03 Feb 2011 15:05:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pl5Qn-0000HN-4D for emacs-orgmode@gnu.org; Thu, 03 Feb 2011 15:05:30 -0500 Received: from vscane-a2.ucl.ac.uk ([144.82.108.42]:57684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pl5Qm-0000D5-W5 for emacs-orgmode@gnu.org; Thu, 03 Feb 2011 15:05:29 -0500 In-Reply-To: <871v3pp3e3.fsf@gmail.com> (Eric Schulte's message of "Thu, 03 Feb 2011 08:02:19 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: =?utf-8?Q?S=C3=A9bastien?= Vauban , emacs-orgmode@gnu.org "Eric Schulte" writes: [...] > > Hi Seb, > > Thanks for sharing this code. I couldn't help myself but to turn it > into a patch as that has become my favorite way of reviewing new code. > The resulting patch it attached. Seb's code worked for me but your patch doesn't unfortunately. > I noticed a couple of issues in the applied patch (possibly due to a > transcription error on my part). Namely Possibly? > - I believe your default faces only work for white backgrounds I have a white background and it doesn't work either but did. > - I didn't notice a change in background for the code blocks ditto with the patch. > - it seems that the #+end_src line is fontified but the #+begin_src line > is not I have the opposite (!) with your patch. I'm not sure what is wrong with the patch but there definitely must be some error unless something else has creeped in with normal org updates since yesterday. -- : Eric S Fraga (GnuPG: 0xC89193D8FFFCF67D) in Emacs 24.0.50.1 : using Org-mode version 7.4 (release_7.4.304.g71203.dirty)