From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: [PATCH] Re: TODO state change from TODO to DONE blocked
Date: Fri, 04 Mar 2011 19:46:35 +0100
Message-ID: <87sjv2bu5w.fsf@gnu.org>
References: <80lj15yab6.fsf@somewhere.org> <80wrkp4dwo.fsf@somewhere.org>
	<87pqqeafov.fsf@gnu.org> <80hbbjq690.fsf@somewhere.org>
	<80d3m6rk6e.fsf_-_@somewhere.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=55893 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pva1Z-0004IW-Le
	for emacs-orgmode@gnu.org; Fri, 04 Mar 2011 13:46:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1Pva1X-0001KG-Gz
	for emacs-orgmode@gnu.org; Fri, 04 Mar 2011 13:46:49 -0500
Received: from mail-wy0-f169.google.com ([74.125.82.169]:47029)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1Pva1X-0001K0-8J
	for emacs-orgmode@gnu.org; Fri, 04 Mar 2011 13:46:47 -0500
Received: by wyi11 with SMTP id 11so2749601wyi.0
	for <emacs-orgmode@gnu.org>; Fri, 04 Mar 2011 10:46:46 -0800 (PST)
In-Reply-To: <80d3m6rk6e.fsf_-_@somewhere.org> (=?iso-8859-1?Q?=22S=E9bast?=
	=?iso-8859-1?Q?ien?= Vauban"'s message
	of "Fri, 04 Mar 2011 16:15:37 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: =?iso-8859-1?Q?S=E9bastien?= Vauban <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org

Hi Sébastien,

Sébastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:

>> - if the output message could be updated to make it clear what the reason is,
>>   or can be?
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 3a07cfd..fb60bc6 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10927,7 +10927,10 @@ For calling through lisp, arg is also interpreted in the following way:
>  			(run-hook-with-args-until-failure
>  			 'org-blocker-hook change-plist)))
>  	      (if (interactive-p)
> -		  (error "TODO state change from %s to %s blocked" this state)
> +		  (error (concat "TODO state change from %s to %s blocked "
> +				 "(because of undone child, or "
> +				 "parent with ORDERED property and undone prior sibling)")
> +			 this state)

I'm not in favor of displaying such a long error message: I find it not
easily readable, and it raises too many potential causes for the error.

The user already knows about these various reasons by reading the
docstring of `org-enforce-todo-dependencies', which defaults to `nil'.

Thanks anyway for the patch!

-- 
 Bastien