From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] Add info when reference to remote table is not in the file Date: Fri, 06 Apr 2012 09:43:28 +0200 Message-ID: <87sjghjof3.fsf@gnu.org> References: <80398i5l2j.fsf@somewhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:39255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SG3oU-0005Un-I9 for emacs-orgmode@gnu.org; Fri, 06 Apr 2012 03:42:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SG3oO-0007XV-SQ for emacs-orgmode@gnu.org; Fri, 06 Apr 2012 03:42:29 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:64179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SG3oO-0007WE-JO for emacs-orgmode@gnu.org; Fri, 06 Apr 2012 03:42:24 -0400 Received: by werj55 with SMTP id j55so1651066wer.0 for ; Fri, 06 Apr 2012 00:42:14 -0700 (PDT) In-Reply-To: <80398i5l2j.fsf@somewhere.org> (Sebastien Vauban's message of "Thu, 05 Apr 2012 16:07:16 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Sebastien Vauban Cc: emacs-orgmode@gnu.org Hi Sébastien, thanks for the patch. I wonder if we should trigger an error instead -- why a message? (I don't like using sit-for, it's often worse than getting an error...) About the patch itself, thanks for the effort in adding a ChangeLog, it's close to perfect: just think of starting sentences with a uppercase letter, and of *including* the emacs ChangeLog in the patch. See other commit messages in the git log for reference. Thanks! -- Bastien