emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add info when reference to remote table is not in the file
Date: Fri, 06 Apr 2012 09:43:28 +0200	[thread overview]
Message-ID: <87sjghjof3.fsf@gnu.org> (raw)
In-Reply-To: <80398i5l2j.fsf@somewhere.org> (Sebastien Vauban's message of "Thu, 05 Apr 2012 16:07:16 +0200")

Hi Sébastien,

thanks for the patch.

I wonder if we should trigger an error instead -- why a message?

(I don't like using sit-for, it's often worse than getting an error...)

About the patch itself, thanks for the effort in adding a ChangeLog,
it's close to perfect: just think of starting sentences with a uppercase
letter, and of *including* the emacs ChangeLog in the patch.   See other
commit messages in the git log for reference.

Thanks!

-- 
 Bastien

  reply	other threads:[~2012-04-06  7:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-05 14:07 [PATCH] Add info when reference to remote table is not in the file Sebastien Vauban
2012-04-06  7:43 ` Bastien [this message]
2012-04-06  8:36   ` Sebastien Vauban
2012-04-09 16:01     ` Bastien
2012-04-19 14:10       ` Sebastien Vauban
2012-04-19 14:27         ` Sebastien Vauban
2012-04-19 14:29           ` Nicolas Goaziou
2012-04-21 13:43           ` Bastien
2012-04-23 13:07           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjghjof3.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=wxhgmqzgwmuf@spammotel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).