From: Bastien <bzg@altern.org>
To: Madan Ramakrishnan <madanr79@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Agenda: Fix org-agenda-bulk-toggle when point is at already marked item
Date: Fri, 20 Apr 2012 14:55:37 +0200 [thread overview]
Message-ID: <87sjfyv9yu.fsf@altern.org> (raw)
In-Reply-To: <CAHhKTtEhmD+FGCRwvrs1qD=HiVHjDM=dsrj_eU1cNdPKu=EBJQ@mail.gmail.com> (Madan Ramakrishnan's message of "Sun, 15 Apr 2012 22:29:49 -0400")
Hi Madan,
Madan Ramakrishnan <madanr79@gmail.com> writes:
> * lisp/org-agenda.el (org-agenda-bulk-mark): truly make arg optional
> as advertised by the function
applied, thanks.
> This is my first patch for org so apologies for any inadvertent
> missteps
This is good, but please use plain text emails if possible.
Nick Dokos <nicholas.dokos@hp.com> writes:
> I presume arg can be negative or zero.
A value of arg below 1 doesn't make sense: arg drives the number of
entries that will be marked, so users usually use this for arg > 1.
If (arg < 1) then the function should trigger an error, which it does.
Best,
--
Bastien
prev parent reply other threads:[~2012-04-20 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 2:29 [PATCH] Agenda: Fix org-agenda-bulk-toggle when point is at already marked item Madan Ramakrishnan
2012-04-16 6:36 ` Nick Dokos
2012-04-16 12:07 ` Madan Ramakrishnan
2012-04-16 14:07 ` Nick Dokos
2012-04-20 12:55 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjfyv9yu.fsf@altern.org \
--to=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
--cc=madanr79@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).