[bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing

[bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing

[Kyle Machulis]

In commit abbea596111611a945d73783b3e8790e76599740, the commit message
starts with

- Move org-element.el from contrib/lisp to lisp/.

However, it looks like org-element.el just got deleted, not moved.
This causes much badness when trying to rebuild.

Re: [bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing

[Achim Gratz]

Kyle Machulis writes:
> In commit abbea596111611a945d73783b3e8790e76599740, the commit message
> starts with
>
> - Move org-element.el from contrib/lisp to lisp/.
>
> However, it looks like org-element.el just got deleted, not moved.
> This causes much badness when trying to rebuild.

Thanks for reporting, it seems Bastien missed a 'git add
lisp/org-element.el' before doing this commit (and broke a few other
things with additional changes in the same commit).  I don't know if the
changes in org.el were intended to go live since there is no changelog
entry for those.  If not, they will have to be reverted/changed
seperately but for now things compile and test cleanly again.

Fixed in 6347bf2f72.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

Re: [bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing

[Bastien]

Achim Gratz <Stromeko@nexgo.de> writes:

> Kyle Machulis writes:
>> In commit abbea596111611a945d73783b3e8790e76599740, the commit message
>> starts with
>>
>> - Move org-element.el from contrib/lisp to lisp/.
>>
>> However, it looks like org-element.el just got deleted, not moved.
>> This causes much badness when trying to rebuild.
>
> Thanks for reporting, it seems Bastien missed a 'git add
> lisp/org-element.el' before doing this commit

Indeed.  Thanks for fixing this!

> (and broke a few other
> things with additional changes in the same commit).  I don't know if the
> changes in org.el were intended to go live since there is no changelog
> entry for those.  

There is a general ChangeLog: 

  Also move chunks of declarations and require statements to
  get rid of compiler warnings.

> If not, they will have to be reverted/changed
> seperately but for now things compile and test cleanly again.

I opened a can of wo^W^Wcompiler warnings while moving org-element.el
to core: the way org.el requires libraries or those libraries require
'org is confusing, and there is still room for simplification.  Let's 
do this incrementally.

-- 
 Bastien