emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Le Wang <l26wang@gmail.com>
Cc: Orgmode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-edit-special too much space if starting with empty block
Date: Fri, 09 Nov 2012 01:23:16 +0100	[thread overview]
Message-ID: <87sj8jlj4b.fsf@gmail.com> (raw)
In-Reply-To: <CAM=K+ipumynnMyvsg27xPB9YeeADQO-VZwd8+p3RvK_DHRGHvQ@mail.gmail.com> (Le Wang's message of "Mon, 5 Nov 2012 22:31:01 +0800")

Hello,

Le Wang <l26wang@gmail.com> writes:

> Some tests:
>
> Case 1:
>
> Start with emacs -Q
>
> I insert
>
> "
> #+begin_src javascript
> #+end_src
> "
>
> with point before "#+end_src", I press " C-c ' " to start editing the source
>
> I enter "foobar" into the source buffer and immediately exit with " C-c ' "
>
> Case 2:
>
> restart with
>
> "
> #+begin_src javascript
>
> #+end_src
> "
>
> I've included a patch that fixes both issues.

Thank you for your patch.

Would you mind adding comments in the function in order to explain the
need for two pass. Also, you may want to reverse the if test in order to
get rid of the progn.

Finally, could you provide the patch as "git format-patch" and add
a changelog entry to it?


Regards,

-- 
Nicolas Goaziou

  parent reply	other threads:[~2012-11-09  0:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-05 14:31 [PATCH] org-edit-special too much space if starting with empty block Le Wang
2012-11-08 12:33 ` Le Wang
2012-11-09  0:23 ` Nicolas Goaziou [this message]
2012-11-18  5:49   ` Le Wang
2012-11-23 14:54     ` Le Wang
2012-11-30 13:23       ` Nicolas Goaziou
2012-12-13 14:05         ` Le Wang
2012-12-13 14:05           ` Nicolas Goaziou
2012-12-13 15:15             ` Bastien
2012-12-13 15:53               ` Le Wang
2012-12-13 16:00                 ` Bastien
2012-12-13 18:09                 ` Achim Gratz
2012-12-13 21:53                   ` Le Wang
2012-12-13 22:20                     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sj8jlj4b.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=l26wang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).