From: Eric Schulte <schulte.eric@gmail.com>
To: Oleh <ohwoeowho@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Add ob-J.el
Date: Sat, 21 Dec 2013 11:58:34 -0700 [thread overview]
Message-ID: <87sitmvxnp.fsf@gmail.com> (raw)
In-Reply-To: <CAA01p3pB-xeHz+9qGQoRS7wTPS9MpVSUeLaJf533bz7AzRVX9A@mail.gmail.com> (Oleh's message of "Sat, 21 Dec 2013 18:40:11 +0100")
Oleh <ohwoeowho@gmail.com> writes:
>>> I added ob-J to the org-babel-load-languages customization variable and
>>> it is now compiling with make.
>>
>> The org-mode build and install now fails for me due to the fact that
>> ob-J requires j-console, which seems to be part of the package
>> 'j-mode', and is not part of the standard emacs.
>>
>> Perhaps this should be in contrib, unless the depency on j-console can
>> be factored out.
>>
>
> Hi Rick,
>
> j-console is required currently for :session eval only. Regular eval
> works without it.
> You can remove the top level (require 'j-console) now if you want, or I can
> remove it a bit later when I get push access.
> The top level one isn't needed since it's required again in *-initiate-session.
>
> The actual dependency on j-console to do the work isn't that different
> from when other org-babel implementations depend on nrepl or inf-ruby.
> But as it's just a simple comint interaction, I could eventually
> remove this dependency.
>
> regards,
> Oleh
>
I just removed the top-level require, thanks for reporting.
--
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D
next prev parent reply other threads:[~2013-12-21 19:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 13:51 [PATCH] Add ob-J.el Oleh
2013-12-20 16:13 ` Bastien
2013-12-20 17:12 ` Eric Schulte
2013-12-21 9:05 ` Oleh
2013-12-21 16:14 ` [BUG] " Rick Frankel
2013-12-21 17:40 ` Oleh
2013-12-21 18:58 ` Eric Schulte [this message]
2013-12-20 17:22 ` [PATCH] " Thomas S. Dye
2013-12-21 8:07 ` Oleh
2013-12-24 11:37 ` Oleh
2013-12-24 17:10 ` Thomas S. Dye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sitmvxnp.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).