From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: Bug: Error with org-bibtex export with tags when using custom
 bibtypes [8.2.5h (8.2.5h-82-gd91d4b-elpaplus @
 /Users/leonardaveryrandall/.emacs.d/elpa/org-plus-contrib-20140324/)]
Date: Sat, 19 Apr 2014 20:11:51 +0200
Message-ID: <87sip9nq8o.fsf@bzg.ath.cx>
References: <CAMRQoAkeMtrMm5bjtC1KMocTZ6sk3JU-vDz=6NZbcUSf9icw0Q@mail.gmail.com>
	<CAMRQoAkJS=SneKZrQOMgE1k4jicSUKfN7u=XnF94S33Nm9GY=g@mail.gmail.com>
	<87zjjhnzyf.fsf@bzg.ath.cx>
	<CAMRQoA=jeN_+GJ7aKgHzkAt4LZkT4tjwqABP9aYXBx8ENTtr1Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56063)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WbZkD-0005Sq-33
	for emacs-orgmode@gnu.org; Sat, 19 Apr 2014 14:12:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WbZk3-0002fk-VS
	for emacs-orgmode@gnu.org; Sat, 19 Apr 2014 14:12:04 -0400
Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:58623)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WbZk3-0002fY-NU
	for emacs-orgmode@gnu.org; Sat, 19 Apr 2014 14:11:55 -0400
Received: by mail-wg0-f49.google.com with SMTP id a1so1458293wgh.8
	for <emacs-orgmode@gnu.org>; Sat, 19 Apr 2014 11:11:54 -0700 (PDT)
In-Reply-To: <CAMRQoA=jeN_+GJ7aKgHzkAt4LZkT4tjwqABP9aYXBx8ENTtr1Q@mail.gmail.com>
	(Leonard Randall's message of "Sat, 19 Apr 2014 16:45:22 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Leonard Randall <leonard.a.randall@gmail.com>
Cc: emacs-orgmode@gnu.org

Hi Leonard,

Leonard Randall <leonard.a.randall@gmail.com> writes:

> For some reason ignoring errors doesn't work for me. The new
> function, doesn't add a keywords field to non-standard bib entry
> types, it just puts the tags before the beginning of the bibtex
> entry, which would mess up the resulting bibtex file.

Can you provide a minimal example where I reproduce this bug,
along with your Emacs and Org versions?  It works fine here.

> The regexp functions I used are based on standard bibtex syntax, so
> they should work in all circumstances. I tested my fix under various
> conditions and with various variables set and it worked everywhere I
> tried it.

I trust you on that, it's just that using re-search-forward here
does not seem necessary -- also, you could send an email to the
bibtex.el maintainers about the error being cryptic anyway, and
maybe not needed at all.

> If you are worried about licensing, you could wait  to apply the
> patch until I receive and sign the license, but I think that it is a
> sufficiently small change that it should not be an issue.

I'd rather wait till the paperwork is done, it gives us more time
to sort this out properly.

Thanks again,

-- 
 Bastien