From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: [RFC] [PATCH] ob-core.el: allow the auto-generation of output file names for src blocks. Date: Wed, 14 May 2014 19:46:59 +0200 Message-ID: <87siocqmlo.fsf@Rainer.invalid> References: <1398196476-4773-1-git-send-email-aaronecay@gmail.com> <87bnvt2h6r.fsf@bzg.ath.cx> <87d2g92au5.fsf@gmail.com> <8738h49u2g.fsf@gmail.com> <8761lugqyi.fsf@gmail.com> <87ha55a5tb.fsf@gmail.com> <87tx8wnje4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkdH1-0007q9-CC for emacs-orgmode@gnu.org; Wed, 14 May 2014 13:47:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkdGv-0006um-2x for emacs-orgmode@gnu.org; Wed, 14 May 2014 13:47:23 -0400 Received: from plane.gmane.org ([80.91.229.3]:53890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkdGu-0006uW-TW for emacs-orgmode@gnu.org; Wed, 14 May 2014 13:47:17 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WkdGo-0000Id-Rg for emacs-orgmode@gnu.org; Wed, 14 May 2014 19:47:10 +0200 Received: from pd9eb26a2.dip0.t-ipconnect.de ([217.235.38.162]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 14 May 2014 19:47:10 +0200 Received: from Stromeko by pd9eb26a2.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 14 May 2014 19:47:10 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Aaron Ecay writes: > Thanks again for the feedback. I just pushed the revised patch to master. > >>> I think I would prefer the code in this patch to do nothing in this case >>> (not create a :file value), but for language-specific code that needs a >>> :file to raise an error to prompt the user to add a name. >>> >> >> Fair enough, especially given that this default will be applied to *all* >> code blocks, this seems like a reasonable approach. > > I went ahead with my suggested approach here. That breaks the tests for Octave and Maxima; since you're intentionally not keeping backwards compatibility here this should be fixed in the tests, I'd think. Also, I'd think you should be using "user-error" instead of error to generate the messages. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds