From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: Changes to contrib Date: Mon, 09 Nov 2015 21:53:51 +0100 Message-ID: <87si4erj1c.fsf@gmx.us> References: <87vb9cdauy.fsf@andromedae.feelingofgreen.ru> <87bnb4y527.fsf@gmx.us> <87mvumnbrp.fsf@feelingofgreen.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvtRw-0000qB-Eh for emacs-orgmode@gnu.org; Mon, 09 Nov 2015 15:54:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvtRt-0007bB-8F for emacs-orgmode@gnu.org; Mon, 09 Nov 2015 15:54:00 -0500 Received: from mout.gmx.net ([212.227.17.20]:50584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvtRs-0007b7-VL for emacs-orgmode@gnu.org; Mon, 09 Nov 2015 15:53:57 -0500 In-Reply-To: <87mvumnbrp.fsf@feelingofgreen.ru> (Serge Kosyrev's message of "Mon, 09 Nov 2015 23:44:26 +0300") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: _deepfire@feelingofgreen.ru Cc: emacs-orgmode@gnu.org Hi Serge, Serge Kosyrev <_deepfire@feelingofgreen.ru> writes: > I'm not sure how wise it would be to raise barriers for contribution, > given the current state of the thing.. I don't know what state you refer to. >> Some quick comments from skimming your code (note, I have no idea what a >> taskjuggler is): >> >> I don=E2=80=99t know what you refer to explicitly. But that should be f= ixed, I >> guess. > > I'm sorry, what should be? Sorry, I was referring to this quote by you, which seems to have disappeared: >>> (One immediate nitpick, of course, is that none of the additions >>> are documented..) >> I think you add some more taskjuggle keywords/properties for >> example. > > [...] > >> Also, you introduce a dependency on subr-x, which may or may not be an >> issue since it=E2=80=99s in contrib. > > I'm sorry, I'm not sure what do you mean? I looked at subr-x.el, and > I didn't find any reference to any of those functions.. You use string-join, which is in subr-x. I think subr-x was not a dependency before. >> org-export-map-special-nodes and org-element-multivalued-property are not >> proper names, as they will supposedly only be used in ox-taskjuggler. > > Well, the functions themselves are supposed to be generic. > > There are two ways to name a function, in my mind: > > - by intended application > - by what it does > > ..it's just that I chose the second.. in the futile hope that someone, > sometime will move/use them. : -) Then they are in the wrong library. > If you deem it not to be an appropriate course of thought, I will > change the name, sure. At this point, they lack appropriate names. Rasmus --=20 Summon the Mothership!