From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: proposed change of org-gnus-store-link for nnir groups
Date: Thu, 17 Dec 2015 09:57:29 +0100
Message-ID: <87si31a1vq.fsf@nicolasgoaziou.fr>
References: <86bn9whtym.fsf@biostat.ku.dk> <871tamaynu.fsf@nicolasgoaziou.fr>
	<86y4ctfvpn.fsf@biostat.ku.dk>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39855)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1a9ULb-0006Oi-Fr
	for emacs-orgmode@gnu.org; Thu, 17 Dec 2015 03:55:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1a9ULa-0007UL-IZ
	for emacs-orgmode@gnu.org; Thu, 17 Dec 2015 03:55:39 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:51994)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1a9ULa-0007UD-CF
	for emacs-orgmode@gnu.org; Thu, 17 Dec 2015 03:55:38 -0500
In-Reply-To: <86y4ctfvpn.fsf@biostat.ku.dk> (Thomas Alexander Gerds's message
	of "Thu, 17 Dec 2015 07:14:12 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Thomas Alexander Gerds <tag@biostat.ku.dk>
Cc: emacs-orgmode@gnu.org

Hello,

Thomas Alexander Gerds <tag@biostat.ku.dk> writes:

> great. the updated patch is attached.

It looks good. Thank you. One minor comment below.

> for ORG-NEWS:
>
> ,----
> | *** Links
> | **** Links stored by org-gnus-store-link in nnir groups
> | 
> | Since gnus nnir groups are temporary, org-gnus-store-link
> | now refers to the article's original group.
> `----

OK.

> commit f56d29a57ed965029c1b5f3929f3085423e46f18
> Author: Thomas Alexander Gerds <tag@biostat.ku.dk>
> Date:   Thu Dec 17 06:57:11 2015 +0100
>
>     org-gnus: avoid links to nnir groups

"Avoid"

You also need to refer to the function modified, e.g.,

  * lisp/org-gnus.el (org-gnus-store-link): Articles in an nnir group
    refer to the original group.

Eventually, if you haven't signed FSF papers, you also need to add
"TINYCHANGE" at the end of the message.


Regards,

-- 
Nicolas Goaziou