From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Add preamble support to ob-plantuml.el
Date: Mon, 05 Dec 2016 22:28:46 +0100
Message-ID: <87shq29ib5.fsf@nicolasgoaziou.fr>
References: <87bmwu29yk.fsf@dell-desktop.WORKGROUP>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58020)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1cE0oY-0006Y6-5o
	for emacs-orgmode@gnu.org; Mon, 05 Dec 2016 16:28:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1cE0oX-0004aB-7T
	for emacs-orgmode@gnu.org; Mon, 05 Dec 2016 16:28:46 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:59738)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1cE0oX-0004Zv-24
	for emacs-orgmode@gnu.org; Mon, 05 Dec 2016 16:28:45 -0500
In-Reply-To: <87bmwu29yk.fsf@dell-desktop.WORKGROUP> (Thibault Marin's message
	of "Thu, 01 Dec 2016 23:09:39 -0600")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Thibault Marin <thibault.marin@gmx.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>

Hello,

Thibault Marin <thibault.marin@gmx.com> writes:

> I am attaching a patch adding support for preamble commands to
> ob-plantuml.el.  The string content of the `org-plantuml-preamble'
> variable is added at the beginning of each source block before execution
> (after the "@startuml" string).

Thank you. Some comments follow.

> TINYCHANGE

You don't need to use the TINYCHANGE string since you signed FSF papers
already.

> ---
>  lisp/ob-plantuml.el | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/ob-plantuml.el b/lisp/ob-plantuml.el
> index 9ce65a9..6463585 100644
> --- a/lisp/ob-plantuml.el
> +++ b/lisp/ob-plantuml.el
> @@ -46,6 +46,12 @@
>    :version "24.1"
>    :type 'string)
>  
> +(defcustom org-plantuml-preamble ""
> +  "Preamble added at the top of every plantuml source block."
> +  :group 'org-babel
> +  :version "24.1"
> +  :type 'string)

The :version keyword is inaccurate. It should be :version "25.2". It is
also missing :package-version and :safe #'stringp.

OOC, what is your use case?

Regards,

-- 
Nicolas Goaziou