From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Table (used a "spreadsheet") org-sbe issues when the value is a
 string
Date: Thu, 07 Sep 2017 18:04:01 +0200
Message-ID: <87shfyxzpq.fsf@nicolasgoaziou.fr>
References: <35a64fca-7d01-b382-15f0-568d93af4f61@fgiasson.com>
	<87k2hgakna.fsf@saiph.selenimh> <87efrjn8pu.fsf@linaro.org>
	<87fubzajnu.fsf@nicolasgoaziou.fr> <87d173mrfr.fsf@linaro.org>
	<87a826mt55.fsf@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40759)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dpzHm-0006lC-5R
	for emacs-orgmode@gnu.org; Thu, 07 Sep 2017 12:04:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dpzHh-0005Ur-3X
	for emacs-orgmode@gnu.org; Thu, 07 Sep 2017 12:04:10 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:47097)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dpzHg-0005UD-Th
	for emacs-orgmode@gnu.org; Thu, 07 Sep 2017 12:04:05 -0400
In-Reply-To: <87a826mt55.fsf@linaro.org> ("Alex =?utf-8?Q?Benn=C3=A9e=22's?=
	message of "Thu, 07 Sep 2017 16:21:26 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
Cc: emacs-orgmode@gnu.org, Frederick Giasson <fred@fgiasson.com>

Alex Benn=C3=A9e <alex.bennee@linaro.org> writes:

> So more correctly when org-confirm-babel-evaluate is set it breaks due
> to info not containing a character position for the TBLFM code. I fixed
> this by patching org-babel-check-confirm-evaluate:
>
> modified   lisp/ob-core.el
> @@ -242,7 +242,8 @@ should be asked whether to allow evaluation."
>  		    (and export (equal eval "query-export"))
>  		    (if (functionp org-confirm-babel-evaluate)
>  			(save-excursion
> -			  (goto-char (nth 5 info))
> +			  (when (nth 5 info)
> +			    (goto-char (nth 5 info)))
>  			  (funcall org-confirm-babel-evaluate
>  				   ;; language, code block body
>  				   (nth 0 info) (nth 1 info)))
>
> I'm not sure the goto-char is legitimate anyway as the documentation for
> org-confirm-babel-evaluate says nothing about point being set while it
> executes.

I agree and removed `goto-char'. Thank you for the analysis and the
patch.

Regards,