From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EKG0K61o1F72YwAA0tVLHw (envelope-from ) for ; Mon, 01 Jun 2020 02:32:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YA9zJ61o1F5ILwAAbx9fmQ (envelope-from ) for ; Mon, 01 Jun 2020 02:32:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 81236940145 for ; Mon, 1 Jun 2020 02:32:12 +0000 (UTC) Received: from localhost ([::1]:48312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfaFG-00082Z-TI for larch@yhetil.org; Sun, 31 May 2020 22:32:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfaEo-00082C-MW for emacs-orgmode@gnu.org; Sun, 31 May 2020 22:31:42 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:56910) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfaEm-0004Ei-KO for emacs-orgmode@gnu.org; Sun, 31 May 2020 22:31:42 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 79080D2C7F; Sun, 31 May 2020 22:31:37 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=SEYU+T2wKax+Pz5kln5gCEynGtE=; b=l8Q1vy 2xxDIiaOhKIn+CaBF+VAHCEDSgsXdh11myiniiqgUfyeu6h3zeZDeHiXzIRlK9ps 5IgK2DOO6ki7oWmAnoEV5HHj0hYtaJ9y3tlTckU3+WCGY2yV2FsemYo3JxT7N92m wUqPRBIPybAki+i34nU/Es8MdH9nmVVtQ1gNk= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 71C10D2C7E; Sun, 31 May 2020 22:31:37 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=nrXaDaFqvXJKp0exkMJULNsDTD0I7JVTn/gEbMWQBHY=; b=H8Q5lTL7Ow6vgukrlsjkAwVuis8OvLG1k5ren3Zzbg4wXgj4iKfeVRadQZs5VNFC0Xpprd4ic0j2Uje8JnwQcZC1S/05UTjLXVwyZiE0vPPO6mTjFIXK8s062s0qCYYfFgjNPhVwHMtiYLzSUU7I264y6RE9tYUuHhOjo+07FC8= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id B4FECD2C7D; Sun, 31 May 2020 22:31:33 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Mario Frasca Subject: Re: `with` as a list. In-Reply-To: References: <87h7vxuq8i.fsf@kyleam.com> <1a448b21-cdf9-467d-e707-471bb8c01781@anche.no> <874krvvdr3.fsf@kyleam.com> Date: Mon, 01 Jun 2020 02:31:31 +0000 Message-ID: <87sgfftt30.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 025E6180-A3B0-11EA-A7C9-B0405B776F7B-24757444!pb-smtp20.pobox.com Received-SPF: pass client-ip=173.228.157.52; envelope-from=kyle@kyleam.com; helo=pb-smtp20.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/31 22:31:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=l8Q1vy 2; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=H8Q5lTL7; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: dpZEvLRDNcVc Mario Frasca writes: > On 31/05/2020 19:19, Kyle Meyer wrote: >> You've been sending a diff, >> presumably from the point you branched off of to the tip of your branch. >> In that case, you're already presenting each iteration you've sent as >> one change; it just lacks a commit message. > > right, that's indeed what I did, and this is also what I thought, so no > need to rebase, squash or whatever, as long as I make sure that the diff > I'm sending you is about this single issue, and let's agree on the > commit message, because after all I'm adding a function to a software I > don't really know. The way to add the commit message to the patch you're sending is to create a commit in your repository with the commit message and then convert that commit to a patch with `git format-patch'. When you send the patch, the commit message can then be reviewed along with the code change. The contributing page that I linked to before () has some information on the expected commit message format and on using format-patch.