emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Mark Barton <mbarton98@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: Bug: tab key no longer bound to org-cycle in commit 565361eb69 [9.4.6 (9.4.6-10-gee652a-elpaplus @ /Users/bartm002/.emacs.d/elpa/org-plus-contrib-20210705/)]
Date: Thu, 08 Jul 2021 10:47:51 +0200	[thread overview]
Message-ID: <87sg0pp4y0.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <E2C88A05-A498-4CE2-9DDE-59E746672D11@gmail.com> (Mark Barton's message of "Wed, 7 Jul 2021 21:18:27 -0700")


Mark Barton <mbarton98@gmail.com> writes:

> So I put back the mapping in org-key.el to map TAB instead of <tab> in my local copy and instead commented out line 185 in outline.el to get TAB to map to org-cycle.
> ——snippet from outline.el
> (defvar outline-mode-cycle-map
>   (let ((map (make-sparse-keymap)))
>     (let ((tab-binding `(menu-item
>                          "" outline-cycle
>                          ;; Only takes effect if point is on a heading.
>                          :filter ,(lambda (cmd)
>                                     (when (outline-on-heading-p) cmd)))))
>       (define-key map [tab]       tab-binding)
>       (define-key map (kbd "TAB") tab-binding)
>       (define-key map (kbd "<backtab>") #'outline-cycle-buffer))
>     map)
>   "Keymap used by `outline-mode-map' and `outline-minor-mode-cycle'.")
> Does that sound like the right thing to do? If so then I could submit
> it to the Emacs dev list.

There are multiple solutions to this. But, as I wrote, you ought to
answer in the other thread I mentioned, the one that initiated this
change, and probably to Emacs Devel.

Nicolas Goaziou

      reply	other threads:[~2021-07-08  8:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07  1:05 Bug: tab key no longer bound to org-cycle in commit 565361eb69 [9.4.6 (9.4.6-10-gee652a-elpaplus @ /Users/bartm002/.emacs.d/elpa/org-plus-contrib-20210705/)] Mark Barton
2021-07-07 12:23 ` Eric S Fraga
2021-07-07 13:35   ` Nicolas Goaziou
2021-07-07 14:11     ` Eric S Fraga
2021-07-08  4:18     ` Mark Barton
2021-07-08  8:47       ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg0pp4y0.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=mbarton98@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).